search

DacoTaco / priiloader

A Wii homebrew application that can prevent and fix some user level bricks
GNU General Public License v2.0
544 stars 101 forks source link

Code Cleanup #265

Closed urherenow closed 3 years ago

urherenow commented 3 years ago

There seems to be a few unused variables floating around. I'm not a real programmer, but doesn't cleaning these out save space?

priiloader/Installer/source/main.cpp: In function 's8 PatchIos(s8)': priiloader/Installer/source/main.cpp:1392:5: warning: unused variable 'downgrade_fix' [-Wunused-variable] 1392 | u8 downgrade_fix[] priiloader/Installer/source/main.cpp:1395:5: warning: unused variable 'trucha_hash1' [-Wunused-variable] 1395 | u8 trucha_hash1[] priiloader/Installer/source/main.cpp:1396:5: warning: unused variable 'trucha_hash2' [-Wunused-variable] 1396 | u8 trucha_hash2[] priiloader/Installer/source/main.cpp:1399:5: warning: unused variable 'identifyCheck' [-Wunused-variable] 1399 | u8 identifyCheck[]

DacoTaco commented 3 years ago

hehe, i know about these ye. hehe, i know about them.

they are unused when patching the running IOS , and therefor don't influence the installer's dol size (because gcc doesn't include them in the binary) but it is cleaner for them to not be there.

however, they are actual IOS patches and i don't know what to do with them. i should delete them, but then i don't have them on my computer if i were to ever need them. :/ they are a bit of a storage place at this point xD

urherenow commented 3 years ago

Put them in a comment(s) in the code. Problem solved.

DacoTaco commented 3 years ago

i solved it differently :P

i removed them from the installer code and moved it to my own channel code (which ive had on my pc for a long time and is based on priiloader ). the channel code is now also on git for shits and giggles