search

DacoTaco / priiloader

A Wii homebrew application that can prevent and fix some user level bricks
GNU General Public License v2.0
544 stars 101 forks source link

`No-Delete ...,RZDx` not working #287

Open kipcode66 opened 3 years ago

kipcode66 commented 3 years ago

Describe the bug The No-Delete HAXX,JODI,DVDX,DISC,DISK,RZDx option in the Settings menu does not allow for a modified Twilight Princess save file to be copied over to the console.

To Reproduce Steps to reproduce the behavior:

Version 0.9.1

Expected behavior The save file should copy over to the console without errors.

Additional context I have been working with 2 other people on a program that would allow to load custom code into Twilight Princess (code RZDE). I have been told that Priiloader could (un)patch the fix from Nintendo that would prevent modified saves from getting copied over, but Using the latest release (0.9.1), I have not been able to load a save modified using the program, but I have been able to load a save from an other game, also modified in a similar way using the same script.

TheTechRobo commented 3 years ago

I speak French, and (for those that don't) that error message means "The copying of the data might have failed"see below for more details (or something similar).

The file is probably corrupt. You might not have saved it correctly. The only deletion that Priiloader is fixing is the deletion on boot; if normal Twilight Hack copies correctly , I don't think this is a Priiloader issue.

More information on that French sentence, because I like to flex :P `La` is the feminine version of `The`. `copie` means `to copy`, `des` is the plural of `The` but with an indeterminate amount of things (bad explanation ik), `données` means `data`, `a` means to have (in this context), `peut-être` means `maybe` or `might` which the `a` contemplates (making `might have`), and finally `echouée` is `failed`.
DacoTaco commented 3 years ago

what happens if you put the save on an SD card , boot system menu and then insert the sd into the wii? the hack indeed prevents the whole deletion thing, but im not sure what system menu does besides on startup. would it delete it, refuse to copy it, or throws the data corrupt error message?

its been too long since the creation of the twilight hack and i have no idea how system menu interacts with it. thanks for that translation btw. despite that i should know french, i don't haha.

Masamune3210 commented 3 years ago

There is a check in later System Menu's to disallow the copy if the TP hack is detected, but it only applies to the first save in the pack, and was worked around by adding the hacked save into the third slot iirc, maybe make sure you are using the latest version of the hack?

Masamune3210 commented 3 years ago

also, make sure you have a TP save already on your consoles' nand before trying to copy the exploit

kipcode66 commented 3 years ago

also, make sure you have a TP save already on your consoles' nand before trying to copy the exploit

When I try to copy any file over an existing one, the menu won't allow me to copy the file over for any game or any save (hacked or original).

The file is probably corrupt. You might not have saved it correctly. The only deletion that Priiloader is fixing is the deletion on boot; if normal Twilight Hack copies correctly , I don't think this is a Priiloader issue.

It shouldn't be corrupt, since I'm able to load the file through Dolphin and SaveGame Manager GX. I also verified the signature and the certificate and it's valid according to Dolphin's algorithm. Also, using the same algorithm, and using an other game's save, the modified save copies over to the console without a problem.

There is a check in later System Menu's to disallow the copy if the TP hack is detected, but it only applies to the first save in the pack, and was worked around by adding the hacked save into the third slot iirc, maybe make sure you are using the latest version of the hack?

I made the script for the hack myself, and the current save I tried to use has the hack on the 3rd file already.

There is a check in later System Menu's to disallow the copy if the TP hack is detected, but it only applies to the first save in the pack, and was worked around by adding the hacked save into the third slot iirc, maybe make sure you are using the latest version of the hack?

Even when I put the SD Card in after the boot menu, the problem lies when I try to copy the file over from the SD Card to the console. It basically throws the message above that the copy "might have failed".

DacoTaco commented 3 years ago

i don't know what to do with this one to be honest.

the patch patches out a function call ( FUN @ 000379a8 ) which probably does the check & deletion. i checked in ghidra, and the one call that patched out is the only one. so it must have some checks somewhere else too, but i have no idea where and without somebody who knows where to look, fixing this would require a system menu disassembly to go through the save menu :/