Updating from Priiloader 0.9 seems to fail

DacoTaco / priiloader

A Wii homebrew application that can prevent and fix some user level bricks

GNU General Public License v2.0

544 stars 101 forks source link

Updating from Priiloader 0.9 seems to fail #288

Closed InternalLoss closed 3 years ago

InternalLoss commented 3 years ago

Describe the bug When trying to update Priiloader 0.9, error getting versions from server appears.

To Reproduce Steps to reproduce the behavior:

Select Check for Updates

Version Priiloader 0.9 (r0x03225439 - this might be a Wiimmfi test build)

Expected behavior Priiloader 0.9.1 update appears.

Additional context I can see the request succeeds via packet capture: the data is 0000005bc1995e11aae6b57df571917396966a7b4d8fc2a10000005a000000040c4365bbb377d9a468f7cd58d285299ad08c75b1

DacoTaco commented 3 years ago

hm. thats odd. the content does seem to be correct (and its downloading the bin instead of the dat if wireshark is correct). you are sure this is what the wii received? did it also try to get a version.dat ?

the error is shown if the downloaded data size is 0, there is no data or the size of the received data is not correct (it expects 52 in the current 0.9 builds )

also, commit 0x3225439 is the 0.9 tag, so this either the release build or a custom build.

DacoTaco commented 3 years ago

eug, problem found. its a combination of my webhost suddenly sending http headers in lower case (and not camel case) and my shitty http parser (of when i didn't know fully what i was doing).

this sadly means that all online updating is down again and only a bugfix can fix it...

guess ill beter start planning to rewrite the http parser... -_-

(and i don't even find time to do all the other stuff needed in priiloader looks at issue tracker )

InternalLoss commented 3 years ago

oops! sorry for introducing more bugs >_<

On 9 Sep 2021, at 16:48, DacoTaco @.***> wrote:

eug, problem found. its a combination of my webhost suddenly sending http headers in lower case (and not camel case) and my shitty http parser (of when i didn't know fully what i was doing).

this sadly means that all online updating is down again and only a bugfix can fix it...

guess ill beter start planning to rewrite the http parser... -_-

(and i don't even find time to do all the other stuff needed in priiloader looks at issue tracker )

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

DacoTaco commented 3 years ago

no its fine. i'd rather have it known and fixed. i just don't know when ill get to ever release 0.10 xD ( which has the dvd stuff and usb stuff if i ever find time to look at why that is an issue to begin with)

DacoTaco commented 3 years ago

i shouldn't have done this (due to my cold/health) but i kinda fixed the issue. you can test it with the attached installer. there won't be any updates (obviously) , but it will download the version file correctly. thanks for the investigation. it helped to find the issues :)

DacoTaco commented 3 years ago

seems i was a bit to quick to commit & close this issue. had a few bugs in the new parser ( it was 1AM after all... )

this should have it all fixed @InternalLoss boot.zip

InternalLoss commented 3 years ago

Can confirm, I now get no major updates :)