DacoTaco / priiloader

A Wii homebrew application that can prevent and fix some user level bricks
GNU General Public License v2.0
544 stars 101 forks source link

Hack Enable Status - Index Bug #355

Open Ingunar opened 1 year ago

Ingunar commented 1 year ago

Describe the bug Changing the hack position or adding new hacks to the hacks_hash.ini will display the incorrect enabled or disabled status inside the System Menu Hacks section.

To Reproduce If you add new hacks or move the hacks anywhere except the bottom of the hacks_hash.ini list, the Priiloader reads the hack status based on the Index position previously set. (Hacks not compatible with the system menu version count too)

Version 0.10.0

Expected behavior The hacks enabled and disabled flags should match the previously set settings.

Additional context This leads to full confusion about what is happening when saving new settings.

DacoTaco commented 1 year ago

euh, adding a hack should show all hacks disabled iirc? or thats at least what the code should be doing :p

Ingunar commented 1 year ago

Hmm trying to remember...

Does it check if you added/removed a hack with the same name? Since we added and removed some min/max versions.

Ingunar commented 1 year ago

hacks_hash (1) hacks_hash (2)

From the Discord conversation:

I replaced the first one via FTP, and used WiiU Priiloader Forwarder, and checked the enabled/disabled flags

DacoTaco commented 1 year ago

if the amount of hacks stays the same it might be confused, but if the hacks amount changed they should all be disabled just to clarify

Ingunar commented 1 year ago

Okay, we can be sure about these two cases: