search

DadSchoorse / vkBasalt

a vulkan post processing layer for linux
zlib License
1.24k stars 52 forks source link

Testing needed on AMD #30

Closed DadSchoorse closed 4 years ago

DadSchoorse commented 4 years ago

vkBasalt now uses a graphics pipeline instead of a compute pipeline and accesses the image through a sampler. As always I am only able to test on NVIDIA, so any help testing the new build before I release it would be appreciated.

If something does not work, please attach the terminal output.

vkBasalt.tar.gz

Ahmed-E-86 commented 4 years ago

I have tested it with the same game that was working with version 0.0.5, and it crashed during loading Darksiders3.txt

But I got this error message during the installation of vkBasalt:

make[1]: glslangValidator: Command not found
makefile:19: recipe for target '../build/tmp/cas.frag.spv' failed
make[1]: *** [../build/tmp/cas.frag.spv] Error 127

System Specs: CPU: Intel I5 4200M GPU: AMD HD 8750M Driver: Mesa 19.2.99 LLVM 10 (Padoka Unstable PPA) Kernel: 5.3.8 OS: KDE neon 5.17 User Edition

DadSchoorse commented 4 years ago

@ahmed-elsayed2017 seems like the shader makefile tried to rebuild. I worked around that now, the build in the first post has been updated.

Ahmed-E-86 commented 4 years ago

@ahmed-elsayed2017 seems like the shader makefile tried to rebuild. I worked around that now, the build in the first post has been updated.

That make it work as before, but the games that didn't work before still the same.

fosspill commented 4 years ago

I assume these changes are in master too. Just built master and have no issues on AMD.

werman commented 4 years ago

It crashes on 5700XT with latest AMDVLK 2019.Q3.6-1 running vkcube:

amdvlk-vkcube.log

It doesn't crash on RADV.

DadSchoorse commented 4 years ago

@werman try vkBasalt.tar.gz

werman commented 4 years ago

Now it works.

Also it works without visible issues on RADV in GTA V and Path of Exile.

DadSchoorse commented 4 years ago

Latest master needs testing: vkBasalt.tar.gz Keep in mind that 32 bit now uses the ENABLE_VKBASALT variable, too.

fosspill commented 4 years ago

Anything specific you'd like us to test on AMD? Any specific configurations etc?

fosspill commented 4 years ago

Regardless, tested with the default config file and I cannot see any immediate issues.

DadSchoorse commented 4 years ago

@fosspill please also test fxaa and cas simultaneously with: effects = fxaa:cas

fosspill commented 4 years ago

Already did, no issues found other than that I didn't like the effect :)

Ahmed-E-86 commented 4 years ago

Now, L.A.Noir doesn't work with the latest version you provided for testing.

DadSchoorse commented 4 years ago

did it work before?

Ahmed-E-86 commented 4 years ago

did it work before?

Yes.

DadSchoorse commented 4 years ago

Can you post the terminal output?

DadSchoorse commented 4 years ago

@fosspill well fxaa is intended for old games without anti-aliasing.

fosspill commented 4 years ago

Ah it wasn't meant as a complaint! I can imagine places where it would be awesome. Point was that both effects seemed to render properly on AMD ;)

Ahmed-E-86 commented 4 years ago

Can you post the terminal output?

LANoire.log

The error message that appears when VKBasalt is turned on LANoire

Ahmed-E-86 commented 4 years ago

@fosspill please also test fxaa and cas simultaneously with: effects = fxaa:cas

I like the combination between the two. Any hope for OpenGL after the success with Vulkan?

DadSchoorse commented 4 years ago

The error message that appears when VKBasalt is turned on

That does not make any sense at all. The error message points towards the reading of the config file. That part of the code should not have been changed...

DadSchoorse commented 4 years ago

I would appreciate some testing of the smaa Branch. Here is a build: vkBasalt.tar.gz

fosspill commented 4 years ago

No issues to report with smaa:cas on AMD for me.

Ahmed-E-86 commented 4 years ago

It woks ok with SMAA on, but the drop of performance is so noticeable. FXAA has no noticeable effect on performance.

DadSchoorse commented 4 years ago

@ahmed-elsayed2017 well that's why the F in FXAA stands for fast. Did you try any games that didn't work before?

Ahmed-E-86 commented 4 years ago

L.A. Noire didn't work with the previous release, but it works fine with the latest release, but The Evil Within still crashes with every release, and I can't test Observation again, because I uninstalled it.

DadSchoorse commented 4 years ago

That's at least something. Oh and I have noticed that SMAA is on ultra at the moment, so the impact is quite heavy. I hopefully find a good way to make this configurable in the config.

fosspill commented 4 years ago

Ultra? And here I was going to request being able to increase the strength of it!

I do have a question though @DadSchoorse ; Does it matter which order the effects are written in? ie: smaa:cas VS cas:smaa

DadSchoorse commented 4 years ago

@fosspill Maybe it is still possible to increase to the strength, I haven't look into the advanced settings. You could also try running stuff like smaa:smaa:cas and see if that looks good. The order of effects is critical, the effects will be run in order from left to right. In general I would run anti-aliasing first and then sharpen, but looks are subjective.

fosspill commented 4 years ago

Tested the newest release with cas:smaa:deband and it works well on amd!

Ahmed-E-86 commented 4 years ago

The Evil Within still crashes with every release.

This game doesn't crash when using AMDVLK + vkBasalt, but only crashes when using RADV.

DistantThunder commented 4 years ago

Using it with :

On Final Fantasy XIV. The game runs with effects applied, nothing to report atm.

TheEvilSkeleton commented 4 years ago

Using vkBasalt on Gentoo with:

Playing GTA V using Proton in Steam; playing with above 60FPS no problem.

DadSchoorse commented 4 years ago

please open a separate issue for future problems.