Dadangdut33 / Screen-Translate

A Screen Translator/OCR Translator made by using Python and Tesseract, the user interface are made using Tkinter. All code written in python.
MIT License
116 stars 15 forks source link

Thank you for creating the software. But can you help me to solve the following problems. #4

Closed nonamebatbai closed 3 years ago

nonamebatbai commented 3 years ago

I tried translating the game tales of arise. doesn't seem to work well with large fonts. And often appear "Please enter some text". Does (Opacity) affect the effectiveness of text detection in the game? How should I adjust the Offset X , Y , W , H, for the software to work best image

Dadangdut33 commented 3 years ago

Thanks for reaching out, if you are not using multiple monitors and your screen scaling is 100% you don't need to set any offset.

As for why it often does not capture any text, it might be because the background behind the text is not clear enough. Tesseract could not detect any text if the background is not clear enough. If there is a setting to set the background opacity behind the text in the game maybe you could try to make it more opaque.

I will try to add more OCR engines, maybe there are better OCR out there. Until then maybe you can try another software. I'm sorry and I hope it helps :)

nonamebatbai commented 3 years ago

I find this software very good . I hope you will improve it even better

Dadangdut33 commented 3 years ago

Thanks, I will try to make it even better :D

nonamebatbai commented 3 years ago

Thanks, I will try to make it even better :D

Thank you very much for the tool. Now it has become more convenient. I have a question. If later this tool is not developed anymore . but the Tesseract software is still evolving. So I just need to download Tesseract software and upgrade, right? Is Tesseract software an OCR?

Dadangdut33 commented 3 years ago

I have a question. If later this tool is not developed anymore. but the Tesseract software is still evolving. So I just need to download Tesseract software and upgrade, right?

I don't know about this one if the API and the methods to use it in python do not change much, then it should be ok to just upgrade the tesseract version.

Is Tesseract software an OCR?

Yea it is a free open source OCR engine, sponsored by google. You can take a look at their repository if you are interested.

If later this tool is not developed anymore

I'm still planning on improving it as long as I have the free time to do it, so you don't have to worry about that for now, but if somehow I dropped this project you can just fork it and improve it on your own, feel free to do so

nonamebatbai commented 3 years ago

Thank you for your hard work I see the software getting better and better I hope you will make the software even better and more convenient thank you so much

nonamebatbai commented 3 years ago

you can make the Error line disappear. "No text entered:please enter some text?"

nonamebatbai commented 3 years ago

It is very inconvenient if the program does not detect the text and then displays that line, making me control the mouse to turn it off, then I will miss the next conversation.

Dadangdut33 commented 3 years ago

Thank you for your hard work I see the software getting better and better I hope you will make the software even better and more convenient thank you so much

Thank you for the kind words, I'm glad that I could be of help :D

you can make the Error line disappear. "No text entered:please enter some text?"

Hmm sure, I can add an extra setting for this, you can expect another release after this.

How about the OCR, do the new options help in improving the text capturing?

nonamebatbai commented 3 years ago

Thank you for your hard work I see the software getting better and better I hope you will make the software even better and more convenient thank you so much

Thank you for the kind words, I'm glad that I could be of help :D

you can make the Error line disappear. "No text entered:please enter some text?"

Hmm sure, I can add an extra setting for this, you can expect another release after this.

How about the OCR, do the new options help in improving the text capturing?

ORC sometimes still has errors. but it was so much better than v1.6 . I hope v1.8 will be even better and more efficient and hope you will fix "No text entered:please enter some text?" Thank you so much for this software

nonamebatbai commented 3 years ago

Actually, I think the current OCR is very good. 90% will work fine. 10% is not very good. if you can make it even better . I'm so glad to hear that

nonamebatbai commented 3 years ago

If you enter the game scenes with light, it will not be able to translate. If the game scenes are dark, the translation is more accurate can you fix this problem?

Dadangdut33 commented 3 years ago

If you enter the game scenes with light, it will not be able to translate. if the game scenes are dark, the translation is very accurate can you fix this problem?

So far I haven't found any real fix for that. Have you tried using the grayscale options?

nonamebatbai commented 3 years ago

If you enter the game scenes with light, it will not be able to translate. if the game scenes are dark, the translation is very accurate can you fix this problem?

So far I haven't found any real fix for that. Have you tried using the grayscale options?

if you do that the game will be very dark .and very difficult to play Because the brightness and darkness of each scene are different

Dadangdut33 commented 3 years ago

if you do that the game will be very dark .and very difficult to play

No I mean the one in the app/Screen Translate setting

nonamebatbai commented 3 years ago

if you do that the game will be very dark .and very difficult to play

No I mean the one in the app/Screen Translate setting

If "grayscale" is enabled, the error "No text entered:please enter some text?" will often appear. Not much has changed either. still can't translate the text with white and gray light

nonamebatbai commented 3 years ago

This is also a problem with many OCR applications. but i think your software is the best

Dadangdut33 commented 3 years ago

If "grayscale" is enabled, the error "No text entered:please enter some text?" will often appear.

ah, looks like it still haven't change much huh. Maybe another ocr engine will help, i will try to add more engine in the future.

I could not solve the problem of that for now, after all i think the tessdata of tesseract by default is not that great when it's hard to distinguish the background and the text. The solution I think is only if there is a trained tesssdata of the language on a certain bright background, you could try to train it yourself if you can.

This is also a problem with many OCR applications. but i think your software is the best

Haha, thanks for the kind words :)

nonamebatbai commented 3 years ago

If "grayscale" is enabled, the error "No text entered:please enter some text?" will often appear.

ah, looks like it still haven't change much huh. Maybe another ocr engine will help, i will try to add more engine in the future.

I could not solve the problem of that for now, after all i think the tessdata of tesseract by default is not that great when it's hard to distinguish the background and the text. The solution I think is only if there is a trained tesssdata of the language on a certain bright background, you could try to train it yourself if you can.

This is also a problem with many OCR applications. but i think your software is the best

Haha, thanks for the kind words :)

you really did a great job. I will wait for better upgrades from you

nonamebatbai commented 3 years ago

Thank you for fixing my software. but show no text entered alert doesn't seem to work when. still appear "No text entered:please enter some text?" and i think 1.7.1 version works better than 1.7.2

Dadangdut33 commented 3 years ago

Thank you for fixing my software. but show no text entered alert doesn't seem to work when. still appear "No text entered:please enter some text?"

What do you mean? I didn't change anything related to that there shouldn't be any problem, did you make sure that the alert is turned off on the setting?

nonamebatbai commented 3 years ago

Thank you for fixing my software. but show no text entered alert doesn't seem to work when. still appear "No text entered:please enter some text?"

What do you mean? I didn't change anything related to that there shouldn't be any problem, did you make sure that the alert is turned off on the setting?

if "show no text entered alert" is checked, it will no longer show ""No text entered:please enter some text?" right?

Dadangdut33 commented 3 years ago

with Capture and Translate seems to be slower than previous versions. despite setting time delay = 0

I think this one is related to the ocr enhancement, cv2 needs quite some time to process the image so it's not really a bug.

if "show no text entered alert" is checked, it will no longer show ""No text entered:please enter some text?" right?

No, you got it backward, If it is checked it will show the alert.

Edit: If you found a bug unrelated to this thread you should create a new issue in order to avoid flooding this issue

nonamebatbai commented 3 years ago

with Capture and Translate seems to be slower than previous versions. despite setting time delay = 0

I think this one is related to the ocr enhancement, cv2 needs quite some time to process the image so it's not really a bug.

if "show no text entered alert" is checked, it will no longer show ""No text entered:please enter some text?" right?

No, you got it backward, If it is checked it will show the alert.

Edit: If you found a bug unrelated to this thread you should create a new issue in order to avoid flooding this issue

ok. I found the software to be perfect thank you so much

Dadangdut33 commented 3 years ago

The issue is fixed for now. If you found any more bugs or want to add more suggestions you can go ahead and create a new issue