DaedalusGame / Soot

An Embers addon
MIT License
12 stars 9 forks source link

[1.12.2] [1.4+] Alchemical Recombulator doesn't work #70

Closed wamc2017 closed 5 years ago

wamc2017 commented 6 years ago

Hi,

here is my setup: 2018-09-10_17 41 54

It works fine with Embers Rekindled 1.4hotfix and Soot 1.3hotfix. If I update to Embers Rekindled 1.5hotfix (or newer), nothing happens... (unless something changed how to use the recombulator, I guess that's a bug)

Tested it with only Embers, Soot and JEI installed.

Thanks for looking into it.

Best regards, wamc

DaedalusGame commented 6 years ago

oh smoke i knew i broke something when i poked around machine upgrades

wamc2017 commented 6 years ago

Any news on this?

anders0nmat commented 5 years ago

well are there news about this? bc im currently playing a modpack where antimony is part of the progress, would feel bad if i have to cheat

TheFlipflop commented 5 years ago

@DaedalusGame any updates on this? :)

ManIkWeet commented 5 years ago

This is a lovely bug...

werwin11 commented 5 years ago

Playing this mod in MSB3 gated and cannot complete the 16 Antimony ingot task to progress. There is no fix in sight?

ManIkWeet commented 5 years ago

I guess not in the near future, you'll have to cheat them in :(

(Or maaaaaaaybe downgrading Soot might work, the last update broke it)

jonuhal commented 5 years ago

It's broken for me using MSB3 server 3.6.0 files that contain Soot-1.3hotfix.jar. I also installed the latest Soot-1.5.jar to try this but that is broken as well. Did not try reverting previous to Soot-1.3hotfix.jar.

iarspider commented 5 years ago

@DaedalusGame I think have a bit of insight on what's wrong. In mixer code you are only looking for regular FluidMixingRecipe, and quit early if a recipe is not found. In Soot code the recipe for Antimony is registered as AlchemicalMixingRecipe, which belongs to it's own Registry.

iarspider commented 5 years ago

I'm a total n00b when it comes to writing MC mods, but one option to fix this would be to add isRecipeValid to upgrades and call it if recipe is not found in regular registry, and only quit if Upgrade returns False. Or maybe just call Upgrade's doWork from else branch of that check and let Upgrade handle recipe checks.

imi0 commented 4 years ago

Ran into this when playing Modern Skyblock 3 Departed. I updated to EmbersRekindled-1.14-hotfix.jar and Soot-1.10-hotfix.jar, but its still not working (or broken again?)

darkelfe14728 commented 3 years ago

Use Soot-1.6 and EmbersRekindled-1.13-hotfix : works fine for me

JakeBaumbaugh commented 3 years ago

Download links to these versions of Soot and Embers Rekindled for convenience.

MerrittK commented 3 years ago

If this is still broken, in latest versions, then this should be re-opened