The download size of this repository is overly large. I'd like to suggest storing the ROM icons in a separate location and downloading them at build time (perhaps even making them optional) and removing the imported code (including the pre-built binaries). There's several package managers now on Windows (Vcpkg, Conan) and for the projects that aren't supported by them, there's FetchContent from CMake that makes it pretty easy to grab dependencies at build time.
This is going to require rewriting some Git history. Specifically, from git blame:
3039f6a65
I haven't found any other commits that do this, but I also haven't looked too much.
The download size of this repository is overly large. I'd like to suggest storing the ROM icons in a separate location and downloading them at build time (perhaps even making them optional) and removing the imported code (including the pre-built binaries). There's several package managers now on Windows (Vcpkg, Conan) and for the projects that aren't supported by them, there's
FetchContentfrom CMake that makes it pretty easy to grab dependencies at build time.This is going to require rewriting some Git history. Specifically, from
git blame:I haven't found any other commits that do this, but I also haven't looked too much.
This is related to issue #29.
I would be glad to submit a PR for this.