Closed Daeer-Projects closed 2 years ago
I think I also need to split out the connection string options from the backup path options. The execution timeout will be required for backup and restore operators.
I have taken this idea from the excellent Nick Chapsas.
See his YouTube video at the link: https://www.youtube.com/watch?v=kIkbGXLkc-g
Changes made. Wiki and ReadMe to do still before closing this issue.
I'm going to update the readme to use a more friendly welcome to other contributors.
I've updated the wiki now, so this can be closed.
Describe the bug The
ConnectionOptions
class is created and passed into the operator. The expected pattern to be used is by using a function to set the options from within the consuming class.Expected behaviour The expected pattern should look like this:
Additional context The backup path and the execution timeout have default values, so can be supplied or not as the consuming application chooses.
Breaking Change This pattern will be a breaking change for the library. This pattern is also used mainly for options that have full default values. This library requires the connection string.
Questions As the connection string must be supplied, should this pattern be implemented?