Wrong variable name in hisatgenotype_typing_common.py

DaehwanKimLab / hisat-genotype

GNU General Public License v3.0

23 stars 15 forks source link

Wrong variable name in hisatgenotype_typing_common.py #21

Closed nikolasthuesen closed 3 years ago

nikolasthuesen commented 3 years ago

https://github.com/DaehwanKimLab/hisat-genotype/blob/325f61cd17dd0d853acc9d36e48f6822ddb51380/hisatgenotype_modules/hisatgenotype_typing_common.py#L278

chr should be substituted with chrom if I am not mistaken. This definitely gave me an error before and changing it on my local script fixed the error.

chbe-helix commented 3 years ago

Thank you for noticing this. I will look into it and fix any issues it causes in the next release.

Thanks, Chris

chbe-helix commented 3 years ago

Hello,

The new version of HISATgenotype (1.3.1) has been released and should have a fix for any error you have encountered from this syntax. Let me know if you have any other concerns or issues. Thanks!

Thanks, Chris