search

DaehwanKimLab / hisat-genotype

GNU General Public License v3.0
23 stars 15 forks source link

Wrong variable name in hisatgenotype_typing_common.py #24

Closed nikolasthuesen closed 3 years ago

nikolasthuesen commented 3 years ago

https://github.com/DaehwanKimLab/hisat-genotype/blob/325f61cd17dd0d853acc9d36e48f6822ddb51380/hisatgenotype_modules/hisatgenotype_typing_common.py#L278

The issue, which I brought up earlier has returned. Maybe old code was reused, when going from 1.3.1 to 1.3.2? https://github.com/DaehwanKimLab/hisat-genotype/issues/21

"chr should be substituted with chrom if I am not mistaken. This definitely gave me an error before and changing it on my local script fixed the error."

chbe-helix commented 3 years ago

Hi Nikolas,

Thanks for noticing this oversight! I'll push the change in a few hours. I will not iterate the version tag for this push but it will be on the most recent master branch. I'll let you know when I upload it.

Thanks, Chris

nikolasthuesen commented 3 years ago

Hi Chris Thanks again. Nice work. Nikolas

chbe-helix commented 3 years ago

Hi Nikolas,

It is done. Thank you for your patience!

Thanks, Chris