DaehwanKimLab / hisat-genotype

GNU General Public License v3.0
23 stars 15 forks source link

Add check for samtools in the PATH of the hisatgenotype script #45

Open tinyheero opened 3 years ago

tinyheero commented 3 years ago

Currently, when samtools is not in the PATH, the hisatgenotype script runs to completion but without any output or obvious error messages.

This PR adds a check to ensure that samtools is in the PATH when the hisatgenotype script is run.

Note that this is separated from the samtools check in the setup.sh script as that checks when that script is run (https://github.com/DaehwanKimLab/hisat-genotype/pull/31). It's conceived that samtools was available at that time (e.g. through a conda environment), but then when an end-user runs hisatgenotype they forgot to activate this same environment (I did this by accident). This PR makes sure that the program fails fast so that end-users can be notified right away.