DaehwanKimLab / hisat-genotype

GNU General Public License v3.0
23 stars 15 forks source link

Cannot run hisat-genotype for BAM file #50

Open nikyk opened 3 years ago

nikyk commented 3 years ago

run command: hisatgenotype --base hla --threads 4 --bamfile SRRxxxxxx.bam BAM file is generated previously by STAR 2.7.0 --------------------Python error trace message: Traceback (most recent call last): File "/home/Common/HISAT2/hisat-genotype/hisatgenotype", line 763, in typing_process(args) File "/home/Common/HISAT2/hisat-genotype/hisatgenotype", line 539, in typing_process assert fq_fname_base AssertionError

Additional info: BAM file is found by hisatgenotype script, *.bai index file is successfully built

Questions: 1) Is there some way to run HG for bam files? 2) If yes, is it worth using BAM instead of fq.gz? Is there a benefit?

parkchanhee commented 3 years ago

@nikyk HISAT-genotype has moved to http://daehwankimlab.github.io/hisat-genotype and the HISAT-genotype code in the hisat2 is outdated. I will transfer this issue to the hisat-genotype repository.

chbe-helix commented 3 years ago

Hi Nikyk,

HISATgenotype can use bam files though it is not optimized for it and there may be some unknown bugs. Furthermore, HISATgenotype can not use BAM files aligned to standard GRCh37 or GRCh38 human references. We have designed HISATgenotype to use a custom genotype genome that is optimized for genotyping but has shifted coordinates to any reference. We recommend running HISATgenotype with fastq files for optimal results. Hope this helps!

Thanks, Chris

nikyk commented 3 years ago

Ok, thanks. It would be fruitful to add this note to Manual, where --bamfile option is described

chbe-helix commented 3 years ago

I'll add that to the list of changes. Thanks!

Thanks, Chris

nikyk commented 3 years ago

Feature request: Add descriptive error message in case when input bam isn't aligned to compatible reference.

thomasKuilman commented 2 years ago

I have been trying to run hisatgenotype on an existing bam-file that was created using hisatgenotype (i.e., with the correct reference) but still I get the same issue as reported above:

$ hisatgenotype --base hla --out-dir $OUT_DIR --bamfile $PATH_TO_BAM --index_dir $PATH_TO_INDICIES

Traceback (most recent call last):
  File "/home/thomaskuilman/Neogene_Dropbox/Thomas/tmp/hisatgenotype/hisatgenotype", line 771, in <module>
    typing_process(args)
  File "/home/thomaskuilman/Neogene_Dropbox/Thomas/tmp/hisatgenotype/hisatgenotype", line 539, in typing_process
    assert fq_fname_base
AssertionError

Could you please check whether this is a valid call to hisatgenotype and / or whether there are any issues with HLA-typing from an existing bam-file?