search

Daelso / Warhammer-IS12

A Warhammer 40k multiplayer mod for Space Station 13 built with Dream Maker.
GNU Affero General Public License v3.0
12 stars 60 forks source link

Warhummer #234

Closed TheVanderlin closed 3 years ago

TheVanderlin commented 3 years ago

Read the individual commits for what this changes.

Updates to merchant, descriptions. lore, motd, items, spawners and inquisitorial base.

dr-ehle commented 3 years ago

Pull requests should be atomic, meaning that they concern one subject or area of code. This is for (at least) two reasons: one, it helps with understanding what was changed. Two, it keeps rollbacks small in case of bugs.

This PR is far too broad to be considered reviewable or safe practice to merge. Even if 99% of your code is bug-free, if there is one bug that negatively affects the server at runtime then all of these changes need to be rolled back.

Please make your commits and PR's atomic in the future. Also, informative commit messages are far more helpful than meme-y ones.

Daelso commented 3 years ago

Pull requests should be atomic, meaning that they concern one subject or area of code. This is for (at least) two reasons: one, it helps with understanding what was changed. Two, it keeps rollbacks small in case of bugs.

This PR is far too broad to be considered reviewable or safe practice to merge. Even if 99% of your code is bug-free, if there is one bug that negatively affects the server at runtime then all of these changes need to be rolled back.

Please make your commits and PR's atomic in the future. Also, informative commit messages are far more helpful than meme-y ones.

I agree with this. In the future please make PRs for each change.