Closed illwieckz closed 2 years ago
This is another bug related to fatLightmap.
By dropping fatLightmap code and loading and using internal lightmap the exact same way we load external lightmaps the bug is expected to disappear in the process.
This is not a regression, it never worked.
The lightmap spills out because it is shifted:
What we get (see the shadows around the billboard, repackaged Terminus map from Urban Terror):
What we expect:
It is better seen with a slider: https://imgsli.com/MTIxNTE0
Some other pixel-to-pixel comparisons:
What we get/What we expect:
What we get/What we expect:
Initially reported there: https://github.com/Unvanquished/Unvanquished/issues/782 But the thread reported two issues, this one if for the spilling out lightmap issue.
internal:
external:
The depicted map is the Terminus map, repackaged from Urban Terror metro map.
Released maps usually don't reproduce the bug since we usually use external lightmaps as they compress better. This issue may still bite us in the back later, and we can't assume any Dæmon-based game will repackage every legacy map available on this world, and maybe some may not have the right to.