DaemonEngine / daemonmap

Deprecated navmesh compiler for the Unvanquished game
https://unvanquished.net
Other
3 stars 1 forks source link

Bug Fixes, new -hn flag #1

Closed Xecantur closed 10 years ago

Xecantur commented 10 years ago

FIxed Segfaulting when running ./daemonmap with 0 args, and when trying to generate navMeshes from *.bsp's that don't have brush geometry in a certain order(I'm fairly certain it will catch this but seeing as I can't reproduce I don't know for sure). Also added new help flag "-hn" which is a 3 liner that prints navmesh steps.

dsalt commented 10 years ago

I was just about to reject this as is.

The “-hn” option is badly implemented and is unnecessary; I'd rather that the existing help text is adjusted to mention expected parameters for each option (and this needs to be in a separate commit).

Error messages should be on stderr (std::cerr; I don't care if fprintf is used), although this probably needs fixing up more generally, and you're using the wrong exit code – should be 2, not 0.