Daemonite / discourse-material-theme

Material Design for Discourse
MIT License
21 stars 28 forks source link

Category chooser text color and spacing #10

Closed amotl closed 5 years ago

amotl commented 5 years ago

Problem I

When using the Light Theme, the text color of the category chooser element offers too less contrast for the currently selected item to be visible. This happens to the category chooser while creating or editing a topic.

image

Problem II

After making the text visible, it occurs that the spacing between main and subcategory labels is non-existent.

image

amotl commented 5 years ago

Workaround

/* Adjust category chooser */
.category-chooser {

    /* Add gap between category elements*/
    .selected-name {
        span + span {
            margin-left: 10px;
        }
    }

    /* Clear "color" attribute from badge label elements */
    .badge-wrapper {

        .badge-category {
            color: unset !important;
        }

    }
}

Result

image

sesemaya commented 5 years ago

The dropdown component seems to have quite a few issues since the last update. I've updated all of them in 98b4ddd, 5147ff0 and f2f332c, and these changes should also get this particular problem fixed.

amotl commented 5 years ago

Wow, quite some amount of changes. Thanks again, @sesemaya.