search

Daemonite / discourse-material-theme

Material Design for Discourse
MIT License
21 stars 28 forks source link

Markdown rendering of bullet lists #13

Closed amotl closed 5 years ago

amotl commented 5 years ago

Problem

When rendering a markdown bullet list, no margin is applied after the last item.

Expected behavior

Input

Hello
- one
- two
- three

world!

Output: GitHub renderer

Hello

world!

Output: Discourse with Default theme

image

Erratic behaviour

Output: Discourse with Daemonite Material theme

image

sesemaya commented 5 years ago

Discourse resets the styles (mostlyfont-sizes and margins) of some common elements in .cooked and .d-editor-preview. 3c29660 re-applies the default font-size and margin back on these elements.

amotl commented 5 years ago

Thanks @sesemaya!

We recognize the intrinsic details required to be taken care of when implementing such fixes for real with Sass, in comparison to our humble tweaks we made mostly on the CSS level for ad hoc fixing some things we are listing here. Sorry that we won't be of any help for you resolving the various filed issues on the expert level until possibly reading more on the commit stream and doing hands-on work with Sass ourselves. So, thanks again for taking care!

If you do like the reports we are making in order to eventually assist with further teeth cutting of this excellent theme by also looking at the nitty gritty details and you feel the time is right for this, please let us know.

Saying that, sorry in retrospective for the bulk-filing of the issues to your project the other day. We thought it would be a good idea to have them separated from each other but actually didn't ask before what the preferred way for receiving them would look like for you. As you offered both, the reason we chose GitHub was that we didn't want to clutter the Discourse topic with our ramifications.