search

Daemonite / discourse-material-theme

Material Design for Discourse
MIT License
21 stars 28 forks source link

"Reorder Categories" dialog slightly offscreen #8

Closed amotl closed 5 years ago

amotl commented 5 years ago

Problem

The "Reorder Categories" dialog seems to be rendered slightly offscreen, expanding beyond the viewport towards the top.

However, editing and saving works, so this is just a minor cosmetic thing.

Hope this helps.

amotl commented 5 years ago

Workaround

While the following CSS rule was declared already, it got overridden by some other max-height: none !important rule coming somewhere out of Discourse. This patch adds the original height computation again, which is obviously working correctly as intended.

/* Fix DMT#8: "Reorder Categories" dialog slightly off */
.modal .modal-body.full-height-modal.reorder-categories {
    max-height: calc(100vh - 150px) !important;
}

So, there's not really something to fix here but to investigate why this rule gets overwritten by a nonsense one.

sesemaya commented 5 years ago

This should have been fixed by 4cbc1d3.