search

Daemonite / material

Material Design for Bootstrap 4
http://daemonite.github.io/material/
MIT License
3.2k stars 720 forks source link

Adding @mixin make-col-ready() to grid.scss #166

Closed justlevine closed 6 years ago

justlevine commented 6 years ago

Despite being referenced in the docs (http://daemonite.github.io/material/docs/4.0/layout/grid/#mixins), make-col-ready() was missing from the actual file. All I did was copy the @mixin from the latest Bootstrap v4-release (https://github.com/twbs/bootstrap/blob/v4.0.0/scss/mixins/_grid.scss).

(PS: I see most of the other mixins here deviate from the bootstrap version, but I'm assuming there's a reason for that).

sesemaya commented 6 years ago

I missed this one probably because this mixin is not actually used for compiling the CSS, but you are right, we should include this since it is mentioned in the docs and can be useful for people in custom.scss.

justlevine commented 6 years ago

@sesemaya just to clarify though: the other discrepancies with mixins in that file (and mixins in other files I might come across): If they have a different syntax is it intentional or just overlooked (because who checks a function's input variables) and I should submit a PR?

sesemaya commented 6 years ago

Hi @justlevine feel free to submit PRs. Upon a quick review, I would say that mixins related breakpoint and grid are probably overlooked. Not sure about the others, some may be intentional, some may be due to different linting rules. Again, feel free to submit PRs, even if some are intentional, I maybe at least clarify the reasons for you.