Daemonite / material

Material Design for Bootstrap 4
http://daemonite.github.io/material/
MIT License
3.2k stars 725 forks source link

Update this to latest Bootstrap v5.0.0-beta3 #197

Open ayoubkhan558-zz opened 5 years ago

ayoubkhan558-zz commented 5 years ago

Please Update this awesome library with latest Bootstrap version v4.5.0

mf-berlin commented 5 years ago

Please update to 4.1.3 from 24 Jul 2018 and keep up the good work. https://blog.getbootstrap.com/2018/07/24/bootstrap-4-1-3/

ayoubkhan558-zz commented 5 years ago

Where is owner of this repo. We need update please.

WrDX commented 5 years ago

@sesemaya Will there be updates for this projects in the foreseeable future?

justlevine commented 5 years ago

@sesemaya are there plans for continued development?

modius commented 5 years ago

Yes. We're likely to move direct to 4.2.1 in the New Year.

ayoubkhan558-zz commented 5 years ago

Yes. We're likely to move direct to 4.2.1 in the New Year.

Thank You so much. When this update will come

justlevine commented 5 years ago

@modius any updates? got a new project coming up and debating whether to wait off...

djibe commented 5 years ago

Anyone to help me creating a 4.3.1 branch ?

modius commented 5 years ago

We're in the middle of a large 4.1.1 based build. Once we have completed this project we'll turn our attention to updating to the latest Bootstrap. At this rate we'll likely be targeting 4.3.x

In the mean time if you have issues in 4.1.1 feel free to lobby for fixes.

justlevine commented 5 years ago

Where exactly is this 4.1.1 work happening?

@djibe what would that entail?

modius commented 5 years ago

Where exactly is this 4.1.1 work happening?

We're working on a large internal UI project that is based on the 4.1.1 release of this open source library. We'll patch the 4.1.1 branch of this code base as needed. Once that project is out of the way our next project will be on the latest version of Bootstrap, and so we'll start updating the open source library accordingly.

djibe commented 5 years ago

Can you create a 4.3.1 branch so I can start pulling merge requests ? See you soon.

stsrki commented 5 years ago

@modius Do you have any estimate on when you plan to release an updated version of Material for the latest Bootstrap? tnx

djibe commented 5 years ago

Hi. if you want to help me or try an early 4.3.1 version, here is what I did today : https://github.com/djibe/material/tree/v4-dev

Buttons are not perfect at all.

ayoubkhan558-zz commented 5 years ago

Hi. if you want to help me or try an early 4.3.1 version, here is what I did today : https://github.com/djibe/material/tree/v4-dev

Buttons are not perfect at all.

Love to see this effort from you. Thank you so much.

djibe commented 5 years ago

You can test it here : https://github.com/djibe/material/blob/v4-dev/css/material.css

Thx for your testing. Thix is just a preview.

djibe commented 5 years ago

Here is the demo. Feedback is welcome. Spending my days ......

https://www.diabeclic.com/daemonite/components.html

djibe commented 4 years ago

Hi guys, last round until release of Material 4.3.1 beta 1. Test it here : https://www.diabeclic.com/daemonite/components.html Missing input-group and custom-switch ...

Early feedback is welcome. @sesemaya Can you help me with last efforts ?

stsrki commented 4 years ago

@djibe Looks good to me. Do you plan to create a PR or will you release it on your own branch?

djibe commented 4 years ago

I plan a PR. However I need to finish with last components. And I don't know how to use git commands so I do everything with drag'n drop and it's kind of dirty. Documentation should be updated too (I don't know Jekyll,), dependencies too (I don't know Node)

stsrki commented 4 years ago

Sounds like a mess :) From what I can see on your branch it seems clean and I think you will be able to finish it. I know it can be overwhelming with all this different tools but just keep going.

qool commented 4 years ago

There's about 20 known High security vulnerabilities (DOM XSS, etc.) caused by bootstrap-4.1.1. Those issues are solved in 4.3.1. Affects all sites using this daemonite/material library!

djibe commented 4 years ago

I'm trying to move forward : https://github.com/djibe/material/tree/master/css Now working on Chips elements. Need help on Toggle elements. But don't know anything about Git commands and Node. So any help is appreciated.

Screen Shot 11-06-19 at 09 41 PM

srebelo001 commented 4 years ago

@djibe I'm also looking forward to try the v4.3.1. Do you need any help? I can make some tests for example

djibe commented 4 years ago

@srebelo001 Thanks for your help. Do you know how to upgrade dependencies and NodeJS packages ? Could you style Switches according to BS 4.3.1 HTML markup ?

Best chips ever incoming ;-) Screen Shot 11-08-19 at 04 13 PM

srebelo001 commented 4 years ago

@djibe With npm you can use the following command:

Navigate to the root directory of your project and ensure it contains a package.json file: cd /path/to/project In your project root directory, run the update command: npm update To test the update, run the outdated command. There should not be any output. npm outdated

Regarding the style elements I only have 8 months of experience in Frontend. My career was based in the Backend. I could say I want to learn more about the client-side.... :)

Hope it helps

srebelo001 commented 4 years ago

image

An example when I updated the packages through Node.js command prompt

djibe commented 4 years ago

@srebelo001 Do you succeeed in building Daemonite with npm ? I have a crash after SCSS compilation.

srebelo001 commented 4 years ago

what command did you use?

djibe commented 4 years ago

what command did you use?

@srebelo001 Maybe we should talk in private session. dj ib e 8 9 A hot m ai l . c o m Thanks for your help.

I used : npm install npm update npm run dist

srebelo001 commented 4 years ago

Add me on skype @djibe

live:.cid.db7b9e85741db61a

srebelo001 commented 4 years ago

@djibe

since you ran npm install... try npm rebuild node-sass before npm run dist

djibe commented 4 years ago

Hi, I'm working on 4.4.1 now.

i still cannot build this official 4.1.1 with npm default scripts. If anyone can help.

tiberiumihai commented 4 years ago

I want to help with this one.

@djibe tell me how I can help you out?

djibe commented 4 years ago

Hi @tiberiumihai , what is your mail ?

Do you succeed in building this repo ? My npm run dist throws errors with RollupJS. That would be a cool help.

Another 1 is to style Switches component according to latest Bootstrap HTML markup.

See you.

tiberiumihai commented 4 years ago

@djibe It seems that 'objectSpread2', is not whitelisted in build/rollup.config.js

after adding it in externalHelpersWhitelist it's building fine after upgrading all dependencies to latest, except: "pickadate": "^3.6.4", which has an alpha tag version as latest.

you can check these commits from my fork: https://github.com/tiberiumihai/material/pull/1/commits

djibe commented 4 years ago

@tiberiumihai AWESOME !!!! I'm not good at Git for now. But i'll do it properly soon. Thank you so much

tiberiumihai commented 4 years ago

There are still some linting errors to be fixed for docs. Because of that, ATM it's not building the documentation. I'll fix those as well.

If you tell me how, i can get bootstrap 4.4.1 into the same branch as well and add a pull request afterwards. From where should I get your latest 4.4.1 work?

UPDATE: Fixed docs linting. Now it builds just fine. Now I only need to add bootstrap 4.4.1 files to the branch.

djibe commented 4 years ago

I was wondering : @sesemaya and Daemonite team haven't been there for months.

Shouldn't we

tiberiumihai commented 4 years ago

@djibe @sesemaya That makes a lot of sense.

I can make a PR for making this repo buildable.

And then we can work at bootstrap@4.4.1 upgrade.

What do you think?

djibe commented 4 years ago

Very good.

Please make an updated 4.1.1 repo and I create material 2 repo, since I've been working on it for 6 months. Then we meet there ;-) (and I'll do my best for standard Git commits). (I still have to learn to run Jekyll on Windows and manipulate Jekyll).

You are awesome !

tiberiumihai commented 4 years ago

BTW: I've found also an issue in htmllint package and did a PR overthere as well. Until that gets merged and released in npm, I've disabled the rel="noopener" htmllint check because it's infact included, but linting fails. https://github.com/htmllint/htmllint/issues/266

djibe commented 4 years ago

I am stylelint-ing my rework and have numerous problems.

Do you think build.stylelintrc needs some cleanup/update ? (example single or double quotes, ignore 'Material-Icons' for font fallback).

Thank you for your help, I cannot build with those errors.

djibe commented 4 years ago

@tiberiumihai Docs have the right nav that mirrors main content. Do you have any idea why ? Thank you for everything, huge steps have been made.

image

stsrki commented 4 years ago

@djibe @tiberiumihai Guys is there any progress with the update? Maybe I can also help.

Do you plan to create new repository?

djibe commented 4 years ago

Hi @stsrki You can join the fight here https://github.com/djibe/material/ ;-)

I am struggling updating the docs. Could you style the Switch component according to Bootstrap 4.4 HTML markup ?

Thanks a lot for your help. We are moving very fast now.

stsrki commented 4 years ago

@djibe I'm getting an error:

Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style

when I do npm run dist

djibe commented 4 years ago

Argg...... Looks like my Git didn't convert CRLF to LF (I'm using Windows 10). What OS do you use ?

stsrki commented 4 years ago

I use Windows 10. Also I have changed the .eslintrc.json settings to

"linebreak-style": [
    "error",
    "windows"
  ],

But it is still not working

djibe commented 4 years ago

What IDE do you use ? I use VSCode and .editorconfig file sets my files to LF carriage return. My Git is set to git config --global core.autocrlf true I think