search

Daemonite / material

Material Design for Bootstrap 4
http://daemonite.github.io/material/
MIT License
3.2k stars 725 forks source link

Datepicker issue on Chorme v.73 #214

Closed karlokukavicic closed 5 years ago

karlokukavicic commented 5 years ago

Hi, with the last Chrome update, the datepicker modal doesn't work anymore (the modal open and immediately close itself).

Crick87 commented 5 years ago

Here the same. I hope it could be fix soon.

SullivanPro commented 5 years ago

do you have any news about this bug?

djibe commented 5 years ago

Works perfectly on latest Firefox. But don't know how to investigate this.

agrothe commented 5 years ago

Also noticed this bug in Chrome since the last update.

Here is a minimal reproduction: https://output.jsbin.com/duxiqez

Edit: This is an issue with Chrome, but other repo's have implemented fixes, like here: https://github.com/elastic/eui/issues/1747

djibe commented 5 years ago

It works for me with this modif

line 898 // Bind the document events. $document.on( 'click.' + STATE.id + ' focusin.' + STATE.id, function( event ) {

replaced by $document.on( 'click' + STATE.id + ' focusin' + STATE.id, function( event ) {

Does it for you ? I yes, I'll create a pull request

Crick87 commented 5 years ago

@djibe You rock! :D Thanks!!! It works!!!

djibe commented 5 years ago

Glad to help. I'll submit a PR next weekend

SullivanPro commented 5 years ago

@djibe I've correct my code and it works ! Thx :D

karlokukavicic commented 5 years ago

@djibe Thanks!!! :)

sesemaya commented 5 years ago

Hi all, this seems to be fixed after I updated devDependencies (e12c586ba2883132330f0faebba022c2c04fe38d). The latest changes are in master now and I am not able to reproduce this issue anymore.

Please feel free to reopen this if you still have issues with date picker after this update.

djibe commented 5 years ago

@sesemaya The example in the documentation http://daemonite.github.io/material/docs/4.1/material/pickers/ still doesn't work in Chrome 73. Is the documentation calling an outdated lib ? Or the bug is not yet fixed ?

djibe commented 5 years ago

Ok my fault, it works perfectly now. Thx Maya. Once again

dantheother commented 5 years ago

So, how does one get this working when using the npm version? Stop using 4.1.1 from NPM and... something?

edit worked it out

Open your package.json file Find the line that looks like "daemonite-material": "^4.1.1", and change it to "daemonite-material": "github:Daemonite/material#7e87b1928614485dbc356e80a197117475df609a",

and run npm install again

This will swap from using the npm version to using the version based on commit 7e87b1928614485dbc356e80a197117475df609a (which I'm guessing is the most correct one to pick based on @sesemaya's commits)

HuzaifaSaifuddin commented 4 years ago

Facing same issue with Chrome, Using gem gem 'material-sass', '4.1.1' gem 'bootstrap', '4.1.1'

djibe commented 4 years ago

Hi, you must use my fork now were pickers are fixed : https://djibe.github.io/material/docs/4.4/material/pickers/