Fix errors in Unofficial SmartBuff branch

Daeymien / SmartBuff_Unofficial

Unofficial version for WoW 9.x

19 stars 9 forks source link

Fix errors in Unofficial SmartBuff branch #1

Closed cgiguy closed 6 years ago

cgiguy commented 6 years ago

UnitAura was using spellId (needed index)
There are a zillion COMBATLOG events, use UNIT_SPELLCAST_FAILED instead
Fix OnClick registration to stop error popup

I just did a quick pass on getting SmartBuff to work and realized you had an Unofficial branch. I've merged my changes into your branch and fixed a few things. Please take this for what it is (about 20 minutes of work)!

cgiguy

Daeymien commented 6 years ago

Had actually just gotten done doing all those before I noticed the Pull Req.

Went ahead and merged your work over mine, looks prettier than what I had.

Appreciate it

cgiguy commented 6 years ago

Well, I don't know about prettier! 8-)

My pleasure and good luck!