search

Daeymien / SmartBuff_Unofficial

Unofficial version for WoW 9.x
19 stars 9 forks source link

Buff in Cities #20

Open SilverSaw opened 3 years ago

SilverSaw commented 3 years ago

Hi,

If i am in rested area it is still asking me to buff even if Buff in Cities is disabled. This is annoying, because while you are in city/rested area you don`t care about buffs or conjured items.

Daeymien commented 3 years ago

Sorry it took awhile to respond. I've been sick.

Just checked this and it's working as intended on my end. Could you give me a bit more info:

What version are you using? Is it a specific buff or just any buff?

SilverSaw commented 3 years ago

I am using v9.0.2.3 and it is happening in every rested area, "Buff in cities" is unchecked, playing with warlock class lvl60. Tested in Oribos or Orgrimar the biggest main cities but it is happening in every rested area. All tested reminders are still buffing in the rested areas, Create Healthstone, Grimoire of Sacrifice, Blood Fury, Undeading Breathe, Soulstone. You can see my settings on this picture https://ibb.co/BgF4TqQ

Daeymien commented 3 years ago

Ok, so...

I just copied your exact setup with my lvl 51 warlock and the "Buff in Cities" option is working as it should in all rested areas.

Two things I can tell you to try at this point:

  1. 9.0.2.4 is the latest version. Give that a try and see if it corrects it.
  2. If it doesn't, try the Reset All button at the bottom and see if that corrects it.

Barring either of those working, I'm going to need further information at that point.

SilverSaw commented 3 years ago
  1. Installed
  2. I click Reset All, then checked only Create Healthstone and unchecked "Buff in Cities"
  3. I disabled all of my addons except SmartBuff

It is still casting the buff in the center of Orgrimar or Oribos, rested areas

SilverSaw commented 3 years ago

Level does not matter it was like that, since i installed it in pre-patch even when i was low lvl. I don`t get it what else could affect this functionality.

Daeymien commented 3 years ago

Trying to figure out what possibly could be affecting it, since it's literally just checking for the rested or not and then checking that against the option.

Other thing you can check is, with the game closed, open up the SmartBuff.lua in World of Warcraft\_retail_\WTF\Account\<ACCOUNT>\<SERVER>\<CHARACTER>\SavedVariables and find the line for ["BuffInCities"] = and check that it's false

SilverSaw commented 3 years ago

Checked in row 48 and yes it is false ["BuffInCities"] = false,

Daeymien commented 3 years ago

Ooooooook...

This really shouldn't matter at all, but are you Destro or Afflic just so I can mess around with stuff in the same spec.

SilverSaw commented 3 years ago

I am Affliction Warmode ON

SilverSaw commented 3 years ago

One more thing, i just tried with my alt shadow priest on the same realm level 10 in Orgrimar and it is working as intended. When i check "Buffs in Cities" reminder is popping and when unchecked reminder is not poping. Tested for Shadowform and PW:Fortitude. That is really strange. It seems that something is wrong with my main :D It is like that since i installed the addon in prepatch

Daeymien commented 3 years ago

Ok, that it's working on your alt helps narrow things down a bit.

I'm on dinner break right now but I'll mess around in Afflic with WM on while I'm doing that and hopefully eliminate another possibility.

BTW: I just pushed 9.0.2.6 incase you want to keep current with things.

Daeymien commented 3 years ago

Found it....

Warmode ON

Now, to figure out why it's doing it.

EDIT: Actually, it seems it's anytime you're PvP flagged since it still does it for the 5m after you turn WM off. EDIT2: So, it's doing what it's supposed to as the tip says when you hover over the checkbox for it "If you are PvP flagged, it buffs in any case" So, not actually a bug. I could possibly add an "Even if PvP flagged" sub-option to it, but that'd have to wait for another day.

SilverSaw commented 3 years ago

Nice you found it, good idea for the sub-option.