search

Daeymien / SmartBuff_Unofficial

Unofficial version for WoW 9.x
19 stars 9 forks source link

Grimoire of Sacrifice wrong behavior #21

Open SilverSaw opened 3 years ago

SilverSaw commented 3 years ago

Hi,

Grimoire of Sacrifice must remind for buffing even if we do not have active pet.

First scenario is when you do not have active pet, missing behavior in the addon functionality: Grimoire of Sacrifice reminder must appear blinking. When you click scrollwheel down it must try to cast the Grimoire of Sacrifice spell, because i have no active pet wow client will give me warning message "You do not have a pet.". This will remind me to summon manually my pet depending of the situation and easily cast with the scrolwheel down required Grimoire of Sacrifice buff. Grimoire of Sacrifice reminder must disappear after.

Second Scenario is when i have active pet, this is current behavior in the addon functionality: Grimoire of Sacrifice reminder must appear blinking. When you click scrollwheel down it must try to cast the Grimoire of Sacrifice spell and successfully sacrifice your pet. Grimoire of Sacrifice reminder disappear after.

This way i am constantly forgetting to cast it again, because we do not have active pet all of the time.

Daeymien commented 3 years ago

Correct me if I'm wrong on this as I'm having a bit of trouble understanding what the issue is. This is what I'm getting:

You're wanting Grimoire of Sacrifice to splash the reminder that it's not active whether you have a pet out or not. In which case, I can see both sides of the argument. On the one hand: Yes, having the client yell at you that you don't have a pet when it tries to cast is helpful. On the other hand: It's not really the intent of the addon to hold your hand per se. It's more towards convenience.

Tangentially, GoS has always been an "OH *$%#!" type of thing where it's a situation of "Pet's gonna die in a second, let me get this buff so I don't bite it." and then re-summon the pet afterwards. Why they made it a 1hr buff, I have no idea. If you're running around with GoS up for an hour, you're majorly losing DPS compared to Haunt. The only niche use it has is in M+ by sacrificing your voidwalker for an extra defensive cooldown.

I'm going to leave this open for a bit, if anyone else wants to chime in with their thoughts. As it stands right now, though, I'm inclined to keep the behaviour as-is.

SilverSaw commented 3 years ago

You're wanting Grimoire of Sacrifice to splash the reminder that it's not active whether you have a pet out or not.

Yes

In M+ yes and mostly in PVP situations. Sometimes i am forgetting to summon pet to be reminded to sacrifice it. Actually if i summon my pet i will sacrifice it instantly and i dont need a reminder to do that, if i have grimoire of sacrifice talent i am always using it and i never waiting to use it before my pet die like you said. Additional reminder for pet summoning is not a good idea, because in PVP you are summoning different pets depending of the situation. I played alot main warlock with original smartbuff addon on TBC and WotLK, i am also playing now with another unofficial exported version for classic and that has always been behavior of the addon for this talent. If i have this talent checked it is always to use it, so reminder must remind me to use it with addon hotkey and if i have no pet trying to click grimoire of sacrfiice, client is yelling me that i have to summon pet first to use that talent. Similar addons like smartbuff have this same behavior what i am trying to explain, example is Buffy. I am just nostalgic and that is why i want to use SmartBuff and i am very happy that i found you ramake it for retail. Thanks and i hope you understand me what i mean and approve this change!