Npc fixes - Githubissues

DaftHunk / Portraits-Portraits-Everywhere

Portraits Portraits Everywhere (PPE)

11 stars 7 forks source link

Closed mleduque closed 3 years ago

mleduque commented 3 years ago

Hi @DaftHunk, Here are some suggested fixes for the components that select NPC portraits.

It seems you can't use parenthesized expression with FILE_EXISTS. Fortunately it's not needed.
The prefixes for portrait selection for Jaheira and Viconia should be"JAHEIRA" and "VICONIA" instead of "JAHEIR"and "VICON" (unless you prefer to rename the bmp files)

DaftHunk commented 3 years ago

Hello, thanks for your PR. Your requests seems right, I will just check also in game and if it's okay I will accept it.