DaftHunk / Portraits-Portraits-Everywhere

Portraits Portraits Everywhere (PPE)
https://forums.beamdog.com/discussion/61015/mod-portraits-portraits-everywhere-for-bg1ee-sod-bg2ee-iwdee-eet/p1
12 stars 7 forks source link

bg1ub, bg2ub & bgqe compatibility #5

Open DaftHunk opened 3 years ago

DaftHunk commented 3 years ago

These mods add unique names to commoners so they won't get portraits in the end.

jascmm commented 2 years ago

Hello, I have seen that many characters do not have portraits if the game is installed in another language. Could I collaborate to fix it in Spanish. I was touching in local and I think I would know how to do it, could I collaborate to have it in the same repo and available for the reverybody?

DaftHunk commented 2 years ago

Hello, I have seen that many characters do not have portraits if the game is installed in another language. Could I collaborate to fix it in Spanish. I was touching in local and I think I would know how to do it, could I collaborate to have it in the same repo and available for the reverybody?

Sure, with pleasure. You can make a fork of this repo to do your changes, then when you have finished, do a pull request and I will accept it if the review looks good :)

Ps: feel free to ask if you need help with the translation ;)

jascmm commented 2 years ago

Thanks, I am making some experiments.

I am adding to the S9MP-CLib.tph new lines. For exampe the are:

(~%Crefullname%~ STRING_CONTAINS_REGEXP ~%Bandit%~ == 0) ||

When I look using near infinity a CRE files i've see that as i have installed the game in spanish the creature is named "Bandido" (Bandit in spanish) so I add a new line like this one:

(~%Crefullname%~ STRING_CONTAINS_REGEXP ~%Bandid%~ == 0) ||

But for some reason this change doen't apply. After some investigation i realize no one portrait from 'Category Portraits' is intalling in my BG setup.

Has anything changed that would prevent the installation of these generic portraits in a different language installation?