DaftHunk / Portraits-Portraits-Everywhere

Portraits Portraits Everywhere (PPE)
https://forums.beamdog.com/discussion/61015/mod-portraits-portraits-everywhere-for-bg1ee-sod-bg2ee-iwdee-eet/p1
12 stars 7 forks source link

Spanish translation #7

Open DaftHunk opened 2 years ago

DaftHunk commented 2 years ago

Thanks, I am making some experiments.

I am adding to the S9MP-CLib.tph new lines. For exampe the are:

(~%Crefullname%~ STRING_CONTAINS_REGEXP ~%Bandit%~ == 0) ||

When I look using near infinity a CRE files i've see that as i have installed the game in spanish the creature is named "Bandido" (Bandit in spanish) so I add a new line like this one:

(~%Crefullname%~ STRING_CONTAINS_REGEXP ~%Bandid%~ == 0) ||

But for some reason this change doen't apply. After some investigation i realize no one portrait from 'Category Portraits' is intalling in my BG setup.

Has anything changed that would prevent the installation of these generic portraits in a different language installation?

Originally posted by @jascmm in https://github.com/DaftHunk/Portraits-Portraits-Everywhere/issues/5#issuecomment-974308870

DaftHunk commented 2 years ago

Hello @jascmm,

I created a specific issue for this to be much clearer.

So for the translation you need to make a new folder in https://github.com/DaftHunk/Portraits-Portraits-Everywhere/tree/master/PPE/lang (You can follow the same kind of changes done for FR) and add the installation path in https://github.com/DaftHunk/Portraits-Portraits-Everywhere/blob/master/PPE/setup-PPE.tp2.

I hope it help :)

jascmm commented 5 months ago

I created a pull request to add the spanish trasnlation following yours instructions.

jascmm commented 5 months ago

@DaftHunk Should we close the issue as the code was merge?

DaftHunk commented 5 months ago

Not yet, I will close it when the version 1.1 will be released

jascmm commented 5 months ago

Yeah, make sense. Thanks!