search

DaftMonk / angular-tour

AngularJS directive for giving an interactive tour of your website.
http://daftmonk.github.io/angular-tour/
MIT License
609 stars 137 forks source link

Vertical and horizontal offset control #16

Closed cladera closed 9 years ago

cladera commented 10 years ago

Fixes #15

Extends offset control adding topOffset and leftOffset attributes.

ikb42 commented 10 years ago

I'm keen to see this merged.

booleanbetrayal commented 9 years ago

@cladera - the race is on between you and @jwawi (#26) on this feature. The first to rebase against master, resolving conflicts, presenting a pretty PR for me, wins. =]

The one thing I would like to retain is a deprecated version of offset that translates to the existing horizontal offset, unless the horizontal offset is specified. That way we're backwards compatible for a couple of versions.

Also, just personal preference, but offsetHorizontal / offsetVertical are preferred property names.

booleanbetrayal commented 9 years ago

Implemented via #39