search

DaftMonk / angular-tour

AngularJS directive for giving an interactive tour of your website.
http://daftmonk.github.io/angular-tour/
MIT License
609 stars 137 forks source link

Additional vertical/horizontal offset attributes #26

Closed jwawi closed 9 years ago

jwawi commented 9 years ago

Adds attributes to be used in template to aid in tourtip placement: tourtip-vertical-offset and tourtip-horizontal-offset. There are many cases (especially those involving transclusion) in which the tourtip placement is somewhat inaccurate.

booleanbetrayal commented 9 years ago

@jwawi - would you mind taking another look at this PR and rebase against master, resolving conflicts?

booleanbetrayal commented 9 years ago

@jwawi - it might also be nice if we could keep offset as a deprecated configuration property and translate it to the horizontal offset unless its specified as well. I also noticed that the vertical offset is not being applied, so that will need to be fixed.

jwawi commented 9 years ago

I was deferring to the existing offset property for elements where that was working and only applying my new props where there wasn't a way to change the horizontal or vertical positioning, but it makes more sense to make the new props available to all cases.

I'll update it to retain the original offset, rename my prop to offsetVertical, and apply that to all cases. rebasing patch conflicts from 35 commits and having tons of fun ;)

booleanbetrayal commented 9 years ago

I know ... apologies for that, but there was a lot of work that went into that Improvements PR (#26) that people were clamoring for. Maybe easier to start fresh? Just let me know!

jwawi commented 9 years ago

No worries, I ended up just starting fresh and creating a new PR from branch patch-2. Take a look and let me know if that's what you were looking for.

booleanbetrayal commented 9 years ago

Closing in favor of #39