Closed bartonhammond closed 10 years ago
Hi Barton,
Thank you for your comments! I still personally think its important to enable the use of tracking cookies for keeping the state of the tour, but your approach seems like a reasonable alternative.
You have also highlighted an important use case for the directive. I'll take a look at your changes to see what I can merge. Thanks!
+1
Awesome work @bartonhammond
:+1:
+1
Hi Tyler,
Your Angular Tour is awesome!. Personally, I think it's the best directive I've ever seen for Angular. That being the case, it's current state doesn't support Angular views.
It's instrumental for my project where I expect to have an older generation audience. That being the case, I thought that having a Grand Tour of the entire website super important. Being able to show a user different pages/views and pointing out critical information is extremely critical in lowering the threshold of acceptance.
This request is a step in that direction. See what I have in GitPages: http://bartonhammond.github.io/
Currently Angular Tour has a trying to track state via cookies. Tracking cookies isn't worth while as it's another conceptual model to grasp (why is the tour not starting from the beginning..what's happening?). So I abandoned that. To me, a "Grand Tour" is a tour, no restarting - everyone starts from the beginning and, unless cancelled, continues to the Finish.
Having a "Grand Tour" is what its all about (imo) - take the user through various pages/views and tell them what's happening - what are they looking at and why - exactly what Angular Tour does.
With that in mind, I've made numerous changes - namely with the OrderedList not being a singleton and having the ability to navigate pages/views. I did try to maintain consistency with your work but at times I couldn't figure our the start/end tags - so I restructured the content. Forgive me. Hopefully its not a terrible merge.
I'm sure you could improve on this and make it more "generic". I hope so - Angular Tour is awesome!
I have a working solution for my project and don't necessarily need this merged, it's just that I believe others would benefit from having this kind of "Grand Tour". And I wanted to "give back" as I would have never figured this out on my own - so thank you!
I apologize not knowing GitHub so well - doing the GtiPages for a project using the artifacts from the "dist" dir - I'm baffled. Yeoman is just soooo complex.
Anyway - great job - this is awesome - EVERY Angular project should use this - absolutely.
With much admiration,
Barton