search

DaftMonk / angular-tour

AngularJS directive for giving an interactive tour of your website.
http://daftmonk.github.io/angular-tour/
MIT License
609 stars 137 forks source link

adds attributes for more fine-grained vertical and horizontal positio… #39

Closed jwawi closed 9 years ago

jwawi commented 9 years ago

Adds attributes for additional fine-grained horizontal and vertical positioning of tourtip elements: tourtip-vertical-offset and tourtip-horizontal-offset. Retains original tourtip-offset attribute functionality for users of previous versions.

booleanbetrayal commented 9 years ago

Cool ... see the comments above. Would also be good to update the documentation!

jwawi commented 9 years ago

Everything should be updated now. I rebased/squashed the iterative commits from earlier, updated the documentation, changed scope.ttOffset to scope.ttMargin, changed tourtip-offset to tourtip-margin, and updated the attribute names to tourtip-offset-vertical/scope.offsetVertical and tourtip-offset-horizontal/scope.offsetHorizontal.

I also ran a grunt build to update the dist files. The tests didn't reference offset so they should still be good I think. Take a look and let me know what you think.

booleanbetrayal commented 9 years ago

sweet ... thanks for this PR @jwawi !

jwawi commented 9 years ago

my pleasure! happy to contribute