search

DaftMonk / angular-tour

AngularJS directive for giving an interactive tour of your website.
http://daftmonk.github.io/angular-tour/
MIT License
608 stars 137 forks source link

adding a title to the tour bubble #59

Closed andrebautista closed 8 years ago

andrebautista commented 8 years ago

I think it could be extremely useful to have some division of content since most tutorial steps have a title and then a description. This added an h1 element that can be styled at the users discretion or nothing if the field is left blank.

screen shot 2015-12-09 at 5 49 12 pm

booleanbetrayal commented 8 years ago

We do have template customization support already, but I think this is probably the majority of use-cases as well, so it can go into the default template.

Doing a little house-cleaning. Could you rebase against master real quick and resolve the conflicts? (just rebuild the dist after rebasing). Thanks @andrebautista !

andrebautista commented 8 years ago

@booleanbetrayal I just did a git rebase master while on my feature branch and I got back "current branch title_element is up to date".

booleanbetrayal commented 8 years ago

Make sure you add the main repo as a remote source for your fork. see also

Then you should be able to git rebase -i upstream/master

On Thu, Dec 10, 2015 at 11:15 AM, Andre Bautista notifications@github.com wrote:

@booleanbetrayal https://github.com/booleanbetrayal I just did a git rebase master while on my feature branch and I got back "current branch title_element is up to date".

— Reply to this email directly or view it on GitHub https://github.com/DaftMonk/angular-tour/pull/59#issuecomment-163706922.

andrebautista commented 8 years ago

I thought my rebase would include the last commit where I changed the h2 to h3 but then it just turned into a git mess with I tried to do a git push.

andrebautista commented 8 years ago

This took a little more time than I thought due to git troubles but I think this is where you want this PR to be.

andrebautista commented 8 years ago

Fixed the readme, should be good to go.

booleanbetrayal commented 8 years ago

Thanks!

agrigory777 commented 8 years ago

Hello! @andrebautista @booleanbetrayal Usefull update! However I can't install via bower the latest version. I uninstalled the previous version v0.2.5 - 2015-10-02, and install the package again with bower - and still don't have the latest angular-tour.js file downloaded @version v0.2.5 - 2015-12-10

so. i dont have the tourtipTitle available. Could you please, fix it?

andrebautista commented 8 years ago

I believe this has something to do with bower trying to install the latest release not the latest commit to master, this stack overflow post may help.

http://stackoverflow.com/questions/16949173/how-to-install-latest-untagged-state-of-a-repo-using-bower On Jan 1, 2016 6:45 PM, "agrigory1982" notifications@github.com wrote:

Hello! @andrebautista https://github.com/andrebautista @booleanbetrayal https://github.com/booleanbetrayal Usefull update! However I can't install via bower the latest version. I uninstalled the previous version v0.2.5 - 2015-10-02, and install the package again with bower - and still don't have the latest angular-tour.js file downloaded @version https://github.com/version v0.2.5 - 2015-12-10

so. i dont have the tourtipTitle available. Could you please, fix it?

— Reply to this email directly or view it on GitHub https://github.com/DaftMonk/angular-tour/pull/59#issuecomment-168359439.

juanvillegas commented 8 years ago

@agrigory1982 yea, it is not released yet so bower doesn't pick it up (as far as bower knows, that is an unreleased work in progress). Add this to your bower: "angular-tour": "DaftMonk/angular-tour#0dbaea97cbaaa1bd26589e9c7cf664822ba7534a". That will force bower to update angular-tour to the hash after "#", which contains title attribute as well as all other dev work so far, so use at your own risk ;)