search

DaftMonk / angular-tour

AngularJS directive for giving an interactive tour of your website.
http://daftmonk.github.io/angular-tour/
MIT License
608 stars 137 forks source link

Not working with jQuery 3 #83

Open tvsbrent opened 7 years ago

tvsbrent commented 7 years ago

As part of updating our project's dependencies, I updated our version of jQuery from 2.2.4 to 3.1.1. At that point, the tour tips no longer appeared. I haven't untangled the root of the issue, but once I went back to jQuery 2.2.4, the tips worked again.

Based on the fact there is an open PR against the project to change the selection logic to use document.querySelector in place of jQuery, my guess is that it has to do with the selector logic.

booleanbetrayal commented 7 years ago

@tvsbrent - Have you figured out the issue in relation to jQuery 3.1.1 yet?

localBlackMage commented 7 years ago

@tvsbrent @booleanbetrayal @DaftMonk

The issue stems from jQuery 3.1.1's .fadeIn not appending display: block; to the div.tool-tip container element. Setting tourConfig.animation = false; will get around this issue, but you lose fade in capability.