DaftMonk / generator-ng-component

Component generators for AngularJS
MIT License
31 stars 42 forks source link

Possible broken install via npm #1

Closed covertgeek closed 10 years ago

covertgeek commented 10 years ago

In conjunction with generator-angular-fullstack 2.0.0 (ref issue #, I'm having issues generating anything under ng-component. This also falls into issue #279 on generator-angular-fullstack.

My setup (clean install)

.yo-rc.json

{
  "generator-angular-fullstack": {
    "insertRoutes": "true",
    "registerRoutesFile": "server/routes.js",
    "routesNeedle": "// Insert routes below",
    "insertSockets": "true",
    "registerSocketsFile": "server/config/socketio.js",
    "socketsNeedle": "// Insert sockets below",
    "filters": {
      "js": true,
      "html": true,
      "sass": true,
      "uirouter": true,
      "socketio": true,
      "mongoose": true,
      "auth": true,
      "googleAuth": true
    }
  },
  "generator-ng-component": {
    "routeDirectory": "app/components/",
    "directiveDirectory": "app/components/",
    "filterDirectory": "app/components/",
    "serviceDirectory": "app/components/",
    "basePath": "app",
    "filters": [
      "uirouter"
    ],
    "extensions": [
      ".js",
      ".html",
      ".scss"
    ]
  }
}

I attempted installing via npm using the command below and appear to only get the app directory when it completes.

npm install -g generator-ng-component

Cloning the repository and then using npm link appears to work.

However, when I attempt to run it, I get nothing added.

$ yo ng-component:route test

[?] Where would you like to create this route? app/components/
[?] What will the url of your route be? /test
$ 

Any ideas on what I'm doing wrong? I've attempted the following,

Please note I'm new to nodejs and still learning. If I've done something wacky, please let me know. :)

DaftMonk commented 10 years ago

I'll be looking into this, but see my response to kosz: https://github.com/DaftMonk/generator-angular-fullstack/issues/279#issuecomment-47189317

kosz commented 10 years ago

I'm not gonna open another ticket for the following information, however things are a bit different on my end at the moment, but it's very much related

While investigating #279 on my end, i did

$ npm uninstall -g generator-ng-component

then ran 'npm link' from the root dir of the cloned repo of generator-ng-component. Once I did this, I got the same behaviour as described in this Ticket :

$ yo angular-fullstack:route blah
[?] Where would you like to create this route? app/components/
[?] What will the url of your route be? /blah
$ ls app/components/
ls: app/components/: No such file or directory
$ ls client/app/
account/    admin/      app.coffee  app.scss    main/
$ yo angular-fullstack:route blah
[?] Where would you like to create this route? client/app/
[?] What will the url of your route be? /blah
$ ls client/app
account         admin           app.coffee      app.scss        main 

If I uninstall this link and npm install generator-ng-component in the project, I get the behaviour described in https://github.com/DaftMonk/generator-angular-fullstack/issues/279 again

Another install issue would be that if i want to install the generator globally using -g

$ npm install -g generator-ng-component

it fails saying :

npm ERR! peerinvalid The package generator-karma does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer generator-angular@0.9.1 wants generator-karma@>=0.8.2

npm ERR! System Darwin 13.1.0
npm ERR! command "node" "/usr/local/bin/npm" "install" "-g" "generator-ng-component"
npm ERR! node -v v0.10.26
npm ERR! npm -v 1.4.3
npm ERR! code EPEERINVALID
DaftMonk commented 10 years ago

Found out why the subgenerators were failing: http://stackoverflow.com/questions/22855656/yeoman-generator-does-not-include-subgenerator-after-publishing-to-npm

Published a new version that now has all the missing files.

covertgeek commented 10 years ago

I did a fresh nvm install of node 0.11.13 and then installed ng-component 0.0.4 using npm. It appears everything is working for me at this point.

I appreciate the awesome work and am looking forward to the release of 2.0.0 for angular-fullstack. Haven't experienced the issue @kosz is, but if I'd say my issue is resolved.

DaftMonk commented 10 years ago

@covertgeek Awesome. Well I just updated the angular-fullstack version so it no longer requires ng-component to be installed as a global package, it now uses it as a local dependency. It does require the most current version of yo, 1.2.0.

kosz commented 10 years ago

works great thanks Tyler