search

DagnyT / hardnet

Hardnet descriptor model - "Working hard to know your neighbor's margins: Local descriptor learning loss"
MIT License
514 stars 100 forks source link

Cleanup #8

Closed RealJohnSmith closed 6 years ago

RealJohnSmith commented 6 years ago

I removed (hopefully all) your absolute paths reflecting your local setup. You should never ever push anything like that to any git repo. It is very hard for someone else to use your code afterwards. Also, it was not even consistent (Fixable by simple sed script or something). Hardcoded stuff all over the place and pointing to all kinds of locations in your system (including your "personal" folder, wtf?)

I also made launch scripts (code/run_me.sh and similar) much more robust to use, this way you can actually run it out of the box, and not have to (yet again) fix all paths and stuff.

.gitignore did not include things like .idea and as a result of which there was .idea folder in the repo. You never want that. That is a thing related to local development. What if someone does not use it? You just fill their directory with crap.

And your requirements.txt was not complete. Fixed that as well.

RealJohnSmith commented 6 years ago

You may want to apply this not only to master, but also other branches