search

DagsHub / audio-datasets

open-source audio datasets
https://dagshub.com/DagsHub/audio-datasets
141 stars 23 forks source link

fix broken Discord invite link and clarify project sharing instructions #65

Closed drecali closed 2 years ago

drecali commented 2 years ago

The Discord link on the CONTRIBUTING.md page is invalid. I found a valid link on the DAGsHub homepage. To make sure the link is valid, I used it to join the DAGsHub Discord server.

The instructions for sharing a project on Discord were not super clear to someone unfamiliar with Discord.

Optional: Share the project on DagsHub Hacktoberfest 2021 Discord channel

It sounded like there was a separate DAGsHub Discord server specifically for Hacktoberfest 2021. Coupled with the broken invite link, this could imply that that Hacktoberfest 2021 server is offline.

I tried to clarify the instructions to match what I believe to be the most likely situation: people can share projects in the #hacktoberfest channel on the DAGsHub Discord server. I hope this is right. If there's anything I missed, please let me know. Since Hacktoberfest ends on October 31, I would suggest not mentioning it in the instructions and instead mention the #share-your-project channel.

I see that #63 also wants to fix this same broken link but in README.md. I didn't want to create a conflicting PR or interfere with that PR. Please let me know if I should do anything differently.

image

image

image

drecali commented 2 years ago

Thanks @kingabzpro. Should I make the changes directly in #63 or explain this to the PR author?

I will also look into contributing to the Dataset. I still have some questions about the process.

Also, can you please add the hacktoberfest-accepted label to this PR?

Thanks again!

kingabzpro commented 2 years ago

Thanks @kingabzpro. Should I make the changes directly in #63 or explain this to the PR author?

I will also look into contributing to the Dataset. I still have some questions about the process.

Also, can you please add the hacktoberfest-accepted label to this PR?

Thanks again!

I don't think you need the tag, It will be accepted in Hacktoberfest if successfully merged.