search

DagsHub / audio-datasets

open-source audio datasets
https://dagshub.com/DagsHub/audio-datasets
141 stars 23 forks source link

it’s bad practice to have whitespace in directory names #83

Closed CyberFlameGO closed 2 years ago

CyberFlameGO commented 2 years ago

This is not a last-minute contribution to Hacktoberfest so please don't (incorrectly) label my PR invalid nor spam. My second contribution here will be my next pull request

Proof that this isn't a last-minute contribution: image

nirbarazida commented 2 years ago

Hi @CyberFlameGO

What is this PR for?

CyberFlameGO commented 2 years ago

I felt that putting whitespace in a directory name wasn't a good idea, since it's bad practice to. If you feel like it's unnecessary I don't mind it being closed

On Tue, 9 Nov 2021 at 1:17 AM, Nir Barazida @.***> wrote:

Hi @CyberFlameGO https://github.com/CyberFlameGO

What is this PR for?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/DAGsHub/audio-datasets/pull/83#issuecomment-963095277, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF6BVMHOUECJHOGX7FPQV5LUK65XDANCNFSM5HCGERWQ .

nirbarazida commented 2 years ago

Hi @CyberFlameGO, thanks for the heads up!

I see that the repo's name has _ between words. Closing the PR for now.