search

DagsHub / fds

Fast Data Science, AKA fds, is a CLI for Data Scientists to version control data and code at once, by conveniently wrapping git and dvc
http://fastds.io
MIT License
382 stars 22 forks source link

Fail tests on flake8 failure #63

Closed mohithg closed 3 years ago

mohithg commented 3 years ago

For syntax errors we anyways fail the test, for the other errors we show them as warnings, but if the total count of these exceeds 10 then we throw an error asking user to fix those lint errors

guysmoilov commented 3 years ago

Why only if greater than 10 BTW?

mohithg commented 3 years ago

@guysmoilov just some number because you asked in the ticket to have a certain range, so I thought 10 would be a good start. Its the sum by the way. So if the total weight of issues is 10 then it will fail. Should I reduce it to 5 ?

guysmoilov commented 3 years ago

I guess I don't understand how flake8 works, I assumed we can set a "maximum allowed severity level"

mohithg commented 3 years ago

Then we can do selective error codes like you did for other flake8 test you are already running

mohithg commented 3 years ago

But I have slight preference over testing everything, and not just selected ones. Code is more hygiene that way.