Closed guysmoilov closed 1 year ago
Refactor strategy IMO:
config
or auth
. None
auth
is lower level, you could think about it as a "Getting and storing tokens utility function library" and config
as an orchestrator that decides when it should be called vs. using other methods
There is a lot of copy-pasta of this snippet around the codebase:
dagshub.common.config.token or dagshub.auth.get_token()
This should be refactored. In the meantime, here's a proposed fix specifically for the new data engine code which ignored config obtained from env variables or otherwise.