search

Daivuk / PureDOOM

Pure DOOM - Single Header Doom Source Port
GNU General Public License v2.0
275 stars 22 forks source link

Naming conflicts #8

Closed ColleagueRiley closed 6 months ago

ColleagueRiley commented 6 months ago

LoadMenu causes an error due to it sharing a name with a WinAPI datatype.

I was able to fix this by changing each occurrence of LoadMenu to DOOM_LoadMenu

ColleagueRiley commented 6 months ago

For more context, this is happening when I attempt to include the Winapi headers while using the library.

Although the issue is caused by something on my side, I believe that the library should do more to prevent naming conflicts.

Daivuk commented 6 months ago

Thanks for this finding! Feel free to make a PR for it.

Daivuk commented 6 months ago

Your PR #9 was merged, but I checked too fast. The change are in the single header file, but original doom files were untouched. So if we run the python script to regen the single header, your changes will get overriden.

ColleagueRiley commented 6 months ago

Sorry, I didn't realize the project was organized that way. I'll create a new pull request later today.

Daivuk commented 6 months ago

Thanks, I'm trying to create tests and make sure they run on github actions.

Daivuk commented 6 months ago

Hi @ColleagueRiley , I am running into the same issue while writing my tests, so I will make the change at the same time.