This is a bunch of fixes, all revolving around the heads-up display and text elements that APDoom has added. The first two of them fix game crashes and/or hangs, the others are just to make the visuals a bit prettier and more consistent.
For Doom and Doom II: in draw_apdoom_version, the STCFNnnn lumps were being fetched directly by W_CacheLumpName. This was changed to use hu_font instead.
While at surface level the original method works fine, it had the side effect of setting the tags of any HU font characters used in the version display to PU_CACHE -- it can be freed at any later time if the memory manager wants it back.
Doom already handles the HU font itself, in hu_font, tagged as PU_STATIC -- it expects them to never be freed unless explicitly done.
Because of the above tag change, those patches could be freed out from under the rest of the program. This caused completely random and unpredictable behavior; sometimes manifesting as infinite loops, sometimes as segfaults, sometimes just as random characters disappearing from heads-up displays.
This doesn't apply to Heretic; it handles FontA entirely differently, so the relevant function in that game was not changed.
For all games: Like the above change, the level select screens of both Doom and Heretic previously used the small numbers and key graphics directly. The relevant functions have been changed and moved, so that they can access the statically-allocated versions of those patches instead.
The old behavior usually manifested as numbers disappearing from the HUD (for example, the count of an inventory item in Heretic), followed by a crash shortly after from trying to draw garbage to the screen.
For all games: The word wrapping function for AP messages was rewritten, because it could cause the game to hang.
Previously, if the maximum string length was reached without reaching the edge of the screen, and there were no spaces to separate at, the game would hang in an infinite loop. This is not normally possible in 4:3 aspect ratio, but in widescreen aspect ratios it is possible for someone to send a string of 80 or more 'I's to cause this to happen.
If the string legitimately cannot be word wrapped (because, for example, someone has loaded a PWAD with an excessively large font, where one character exceeds the bounds of the screen), it now bails out entirely, matching the behavior of the rest of the game.
For all games: AP Messages are now always aligned to the left of the screen, regardless of aspect ratio, and even if the aspect ratio is adjusted in the middle of the game.
For Doom II specifically: The menu background that APDoom added now also blacks out the rest of the screen, instead of showing gameplay through it in widescreen aspect ratios.
This is a bunch of fixes, all revolving around the heads-up display and text elements that APDoom has added. The first two of them fix game crashes and/or hangs, the others are just to make the visuals a bit prettier and more consistent.
draw_apdoom_version, theSTCFNnnnlumps were being fetched directly by W_CacheLumpName. This was changed to usehu_fontinstead.PU_CACHE-- it can be freed at any later time if the memory manager wants it back.hu_font, tagged asPU_STATIC-- it expects them to never be freed unless explicitly done.