Daivuk / apdoom

Archipelago Doom is a fork of Crispy Doom to allow multi-world features from Archipelago
GNU General Public License v2.0
9 stars 11 forks source link

Fix sector 95 assignment in DOOM II MAP17 to correctly flag the BFG9000 location as in the Yellow Key area #21

Closed sgrunt closed 3 months ago

sgrunt commented 3 months ago

I observed playing DOOM II in a multiworld recently that the BFG9000 location in DOOM II MAP17 is tagged incorrectly as in the main area, whereas it should be in the yellow key area. Further digging suggests that sector 95 in the info files is incorrectly set as being in the main area.

Running ap_gen_tool with the retagged sector changes nothing in the sources, and makes exactly one changes in the world's Locations.py (correctly updating the region of the MAP17 BFG9000). Since the worlds aren't in this repository, I'll make a separate PR for that particular change.

sgrunt commented 3 months ago

World fix associated with this is at https://github.com/ArchipelagoMW/Archipelago/pull/3705

KScl commented 3 months ago

Confirmed this does fix the sector in question being assigned to the wrong region when I look over it in ap_gen_tool. I was there when you originally ran into this, so.