search

Daivuk / apdoom

Archipelago Doom is a fork of Crispy Doom to allow multi-world features from Archipelago
GNU General Public License v2.0
9 stars 11 forks source link

Cross-platform-friendlify the code #5

Closed N00byKing closed 3 months ago

N00byKing commented 11 months ago

I was bored and saw people trying unsuccessfully to get DOOM running, so I thought I should take that as a challenge. Compiling it does not work, but with these changes and some in onut it does.

I've also tested connecting to a server, no problems.

Attached some reasonings to the PR for the changes

powerlord commented 8 months ago

I don't know if I should make a pull request to your repo or just mention it here, but ./cmake/Findsamplerate.cmake should be renamed to ./cmake/FindSampleRate.cmake

This was done in the Chocolate Doom repo and Crispy Doom repos at some time in the past, but it might have been after APDoom forked from it.

Daivuk commented 8 months ago

Thanks. Sorry I was slow to respond. I will attempt to spend some time on the project in the near future.

N00byKing commented 3 months ago

Had to do it myself, sorry. Having this PR is a must for making portable Linux builds, as I plan to do in the future, but it can't come if it's breaking Windows compilation with it.

With the added NOMINMAX, this now compiles across both platforms.

Don't worry about it, I completely forgot about this tbh ^^'

KScl commented 3 months ago

I wound up remaking the onut changes separately, since latest master needed a few more changes to compile successfully: Daivuk/onut#143

When that's dealt with, I think that'll be everything needed for this PR to land in master and for me to start making Linux builds for future releases.