search

DakaraProject / dakara-server

Server for the Dakara Project
MIT License
8 stars 1 forks source link

Fix `send_to_channel` too strict #134

Closed Neraste closed 4 years ago

Neraste commented 4 years ago

When a view needs to send something to a channel, the channel may not exist at this time. We have to ignore the message that was supposed to be sent in that case.

This PR aims to make send_to_channel more permissive by ignoring messages sent to None.

codecov[bot] commented 4 years ago

Codecov Report

Merging #134 into develop will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #134   +/-   ##
========================================
  Coverage    95.94%   95.95%           
========================================
  Files           63       63           
  Lines         1654     1656    +2     
========================================
+ Hits          1587     1589    +2     
  Misses          67       67
Impacted Files Coverage Δ
dakara_server/playlist/consumers.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 587d10a...e8b8b1c. Read the comment docs.