search

DalgoT4D / DDP_backend

Django app for the DDP platform
GNU Affero General Public License v3.0
9 stars 35 forks source link

remove unused prefect-related functions #542

Open fatchat opened 2 months ago

fatchat commented 2 months ago

Description

The codebase contains deprecated code which needs to be removed. As a first step towards this, remove the functions by following the sheet

https://docs.google.com/spreadsheets/d/1sgh5NtW8MEcYiUcs9GaojtqsTR2Vk_zpX5bF4ef6zzs/edit#gid=0

Goals

Expected Outcome

The program should still work, all tests should pass

Acceptance Criteria

Implementation Details

No new code is to be added

Mockups / Wireframes

N/A

Product Name

Dalgo

Project Name

Dalgo

Organization Name:

Project Tech4Dev

Domain

30 Others

Tech Skills Needed:

Python

Mentor(s)

@fatchat

Complexity

Low

Category

Performance Improvement

Sub Category

Backend, Deprecation, Technical Debt, Beginner friendly

kauxp commented 2 months ago

@fatchat I want to work on this issue. As per my understanding, we have to remove the checked functions in the Excel sheet. Please correct me if I am wrong else I will proceed with the pull request.

fatchat commented 2 months ago

@kauxp yes you're correct... but give me a few days to spec out the issue

you can start by verifying what i put into the sheet. when i tag it as "c4gt community" you'll know it's ready to be worked on

kauxp commented 2 months ago

Just to verify I removed one of the functions mentioned in the sheet and created a draft PR(https://github.com/DalgoT4D/prefect-proxy/pull/111), could you verify if I got it correct? once this issue is ready to solve I will remove the rest of the unused functions.

kauxp commented 2 months ago

@fatchat could you please tell me why are the tests failing?

fatchat commented 2 months ago

@kauxp the github tests fail for you because of how we have (mis)configured our github actions... you and ishan are already talking about this in your prefect-proxy PR

you should be able to run them locally if you run a local Airbyte

fatchat commented 2 months ago

Also for deletion:

fatchat commented 2 months ago

@kauxp now that the prefect-proxy PR has been merged you can start on this if you want to

SreeCharan1234 commented 2 months ago

@fatchat i want to work on this issue as i have a good knowledge of python i can remove all the functions

kauxp commented 2 months ago

Sure, I will be happy to complete this issue, as I understand since we have deleted the unused functions from prefect-proxy codebase now we need to remove all the functions from DDP_backend which calls those removed functions, correct?

  1. for create_shell_block_for_migration, run-tasks-migrate-cmd and set_uuids_in_orgtask_deployment do we need to delete the complete file?

  2. I checked the sheet again and found I missed 2 endpoints to remove in my previous PR, /proxy/blocks/dbtcore/ and /proxy/blocks/dbtcore_edit/{wtype}/. for /proxy/blocks/dbtcore_edit/{wtype}/ do we need to remove

fatchat commented 2 months ago

@SreeCharan1234 , I would usually encourage you to do this but @kauxp has already started on this exercise so I was going to let just them complete it

kauxp commented 2 months ago

Sure, I will be happy to complete this issue, as I understand since we have deleted the unused functions from prefect-proxy codebase now we need to remove all the functions from DDP_backend which calls those removed functions, correct?

  1. for create_shell_block_for_migration, run-tasks-migrate-cmd and set_uuids_in_orgtask_deployment do we need to delete the complete file?
  2. I checked the sheet again and found I missed 2 endpoints to remove in my previous PR, /proxy/blocks/dbtcore/ and /proxy/blocks/dbtcore_edit/{wtype}/. for /proxy/blocks/dbtcore_edit/{wtype}/ do we need to remove

@fatchat could you please clear the doubts?

fatchat commented 2 months ago

@kauxp i'll remove those prefect-proxy endpoints as part of some other PR

regarding the deprecated management commands... let's move them to a subfolder called management/commands/deprecated/

asengupta07 commented 2 months ago

Hey @fatchat, I would like to work on this issue if it is still open. I have worked on django project before and have a good understanding of python, so I am certain I will be able to help.

anandamideShakyan commented 2 months ago

Hi @fatchat, I want to work on this issue. Is it still open?

fatchat commented 2 months ago

@kauxp are you still doing this or can we open it up for others?

kauxp commented 2 months ago

@kauxp are you still doing this or can we open it up for others?

Apologies for the delay, I had my exam this week which is completed now, so I am planning to open a PR for this by tomorrow's EOD.

SreeCharan1234 commented 2 months ago

Open it for others

On Tue, 30 Apr 2024, 11:31 pm kauxp, @.***> wrote:

@kauxp https://github.com/kauxp are you still doing this or can we open it up for others?

Apologies for the delay, I had my exam this week which is completed now, so I am planning to open a PR for this by tomorrow's EOD.

— Reply to this email directly, view it on GitHub https://github.com/DalgoT4D/DDP_backend/issues/542#issuecomment-2086304425, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4TQMDPJU7WZ74GY4MOIRALY77L5PAVCNFSM6AAAAABGAF3EDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBWGMYDINBSGU . You are receiving this because you were mentioned.Message ID: @.***>

fatchat commented 2 months ago

Opening this up for everyone

Look at the google sheet, wherever column F is "-" you should remove the function in column "E"

kauxp commented 2 months ago

Hello, I apologize for the delay in my work, but I was facing some unexpected challenges.

I have made the PR can you review this and let me know if something is there to be updated.

Akshat-Jaiswal-8 commented 1 month ago

Is there anything left in this @fatchat ?

fatchat commented 1 month ago

@Akshat-Jaiswal-8 yes if you want to work on it go ahead

Rishikesh63 commented 1 month ago

@fatchat can i work on this project? i setup partially DDP_bakend and also submitted proposals for DMP project of dalgo.