DalgoT4D / DDP_backend

Django app for the DDP platform
GNU Affero General Public License v3.0
11 stars 40 forks source link

Orschestrate view page issues #586

Open siddhant3030 opened 4 months ago

siddhant3030 commented 4 months ago

@nairabhishek73 we discussed multiple issues today so I'm mentioning it here

https://jam.dev/c/76589a6d-12fb-4fdd-94a4-3aae87428129

  1. I wasn't able to select any of the dbt task when I first selected one of the pipeline to run. Only the custom one I can select. I had to delete all the task which then comes to dropdown. This is shown in the video above

  2. I don't know what numbering does here. I'm confused what should I do when I first see this screen. Should I type number 1 or delete all the tasks and then select one task to run. This looks super confusing and I think we dont need this. Why can't have we just dropdown and by default to "dbt run" or something.

  3. System and Client Info I dont think we need it. We don;t need to explicitly call this. IMO

  4. Why there is not edit option in the custom dbt task? I should be able to go back and edit custom functions https://jam.dev/c/89e95c65-cbdf-42ce-8fcb-5d77f391323d

  5. When we create a dbt function we should be able to select models from the dropdown. I mean select option mean that right? that user should be able to select models which he wants to run. Otherwise its confusing or we should rename it to "type your model" which you want to run https://jam.dev/c/a7e4660d-24c8-49b7-bcf2-d833d6f60c82

@nairabhishek73 I think this all what we discussed today. Please look into this

fatchat commented 4 months ago
  1. the dropdown contains tasks to be selected, the list below contains tasks already selected, displayed in the sequence they will run. we could add some text explaining this to a user
  2. numbering to to indicate the order in which these commands will be run
  3. that's a valid point
  4. nice to have but can do later
siddhant3030 commented 4 months ago
  1. Whatever you've mentioned is not clear at all. UI should be intuitive enough to understand and that's missing here.
nairabhishek73 commented 3 months ago

@fatchat i like the current fix with basic and advanced.

Some small changes for now until users ask for more In advanced could we add to the explanation:

  1. In the textbox 'Select and add a transform task'
  2. If the dropdown is empty then instead of 'no option' say 'All transform tasks have been added'
  3. In the explanatory text below: These are your default transformation tasks. Most users don't need to change this list. If you have configured custom tasks, add them from the dropdown list above.

@siddhant3030 ccould you create a separate issues for 4. 'edit custom dbt task' and 5. dropdown for select and exclude in custom dbt task