search

DalgoT4D / DDP_backend

Django app for the DDP platform
GNU Affero General Public License v3.0
12 stars 41 forks source link

improve repo's pylint score #867

Open Ishankoradia opened 1 month ago

Ishankoradia commented 1 month ago

Currently we have a pylint score of 6.5. Would be great to get it to 8.5.

To do this one will need update the pyproject.toml and set fail-under = 8.5 under the pylint section. Then run pre-commit run --all-files and fix the lint errors seen on console.

Alokih commented 1 month ago

Hi @Ishankoradia , Can I try out this ? Also can you please provide me discord link as I have few doubts related to local setup, I am getting invalid for the link provided

Ishankoradia commented 1 month ago

Yes go for it.

@Alokih you can put your queries here also. Did you try following the steps in readme ?

Alokih commented 1 month ago

Ok @Ishankoradia sir I am trying to setup using docker. Actually I have doubt in .env file, I mean do I need to just populate airbyte & prefect proxy link & run docker ? @fatchat sir ?

Ishankoradia commented 2 weeks ago

@Alokih if you want to run the entire setup you will need prefect proxy and airbyte. But if you just want to run backend you can keep them empty and if you want to keep things simpler you could also create a virtual env & run djang from it.

Let me know your discord user id , i will add you to our server. Sorry for the late response.

adoo100 commented 6 days ago

Hi @Ishankoradia I would love to tackle this issue and am confident that I can get it done :)