Closed amansgith closed 8 months ago
Hi @amansgith , i feel its better to .gitignore
the virtual environment folder since anyway we have requirements.txt
file for dependency.
Just add dalgoenv
folder to gitignore.
Hi @jaiakash Thank you for pointing it out I will surely do it..
I have removed it.. Please check if anything else is required Thank you
thanks @amansgith . also add the various __pycache__
folders to .gitignore
please?
and from the README
you can remove the steps for creating a python virtual environment, just say "run pip install -r ... inside your python environment"
i'll review it later today / tonight
oh and in the settings.py
could you read SECRET_KEY
and DEBUG
from .env
as well? because devs will set these on their system and in production and we don't want git diffs
when we change them
@fatchat Sure Sir! I'll do it right away
Sir @fatchat All the said changes have been applied Thank you for allowing me to contribute to this.. i have learned many new things
Fixes #6
Title
Scaffold new project
Description
Created the basic file strucutre for the Dalgo-admin Application with all the necessary requirements. As per the tasks mentioned in Issue #6 i have completed all the mentioned goals and everything in the acceptance criteria.
Tech Stack used
Goals
Acceptance Criteria
[x] requirements.txt
Screenshots
File Structure of the Django Project and App
Running Postgres database instance connected to django
Running Django server with "Hello World" view
I have tried to stick to the instructions and hope that the PR has everything as per the requirements
Please do let me know if any changes are required. Thank You