Closed vilol-04 closed 8 months ago
@vilol-04 could you add venv
to the .gitignore
and remove the folder from source control please?
@fatchat Is it alright? Also, when I am extending base_sidemenu.html in the infrastructure.html, its css is completely changing. What should I do?
this is definitely coming together. i'm going to make some notes for our mutual tracking
i'm guessing point (4) is related to your css question? i don't know... i would have to spend time on it to figure it out. i tried doing what you did for (3) and django complained:
Invalid block tag on line 17: 'static', expected 'elif', 'else' or 'endif'. Did you forget to register or load this tag?
when it got to the
<img class="logo airbyte-logo" src="{% static '..\static\airbyte-logo.png' %}" alt="Logo">
Now I'll observer that this worked before i put it inside a {% block content %}
so it has something to do with that. you may be able to google a solution from this point
I am not getting any such error in my system @fatchat
@fatchat I have made some changes. Please look into it.
@vilol-04 i have merged aman's PR https://github.com/DalgoT4D/dalgo-admin/pull/23
please merge those changes into your branch
thank you
@fatchat Please review and let me know what to change.
@vilol-04
this is great. now i have one small request:
there is also one bug to fix, something with your bootstrap navbar... see this screenshot
somehow the logo and the menu button are overlapping. hopefully will be easy to fix
everything else is looking good
@fatchat please review
Please review and let me know the changes. @fatchat